Repository navigation
Fix release version lookup after dynamic versioning - #29
Merged
Merged
Conversation
The version became dynamic, so `grep '^version = ' pyproject.toml` matches nothing and the Check Version step exits 1 under `set -eu`. It now reads __version__ from the installed package, which is the source hatchling builds from, and fails with a clear message if that comes back empty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Check Versionstep in the release workflow fails:0.4.0 made the package version dynamic — hatchling reads
__version__from the package — so there is no longer aversion =line inpyproject.toml. The step'sgrep '^version = ' pyproject.tomlmatches nothing, and underset -eua failed grep aborts the job.This was an oversight in #28: the version's source changed without updating the one place that read it.
Fix
Read
__version__from the installed package, which is the same source hatchling builds the distribution from, and fail with an explicit message if it comes back empty.pkg_namestill comes frompyproject.toml, sincenameis static.Testing
Ran the step's script verbatim against a synced checkout:
v0.4.0is whatmark-releaseuses for the tag, matching the previous behaviour.