Skip to content

Add async engine regression coverage for duplicate columns - #36

Closed
CollierKing wants to merge 1 commit into
revert/direct-async-test-pushfrom
fix/worker-result-columns
Closed

CollierKing wants to merge 1 commit into
revert/direct-async-test-pushfrom
fix/worker-result-columns

Conversation

@CollierKing

Copy link
Copy Markdown
Owner

Add unit and real-D1 REST regression coverage for duplicate column names through SQLAlchemy's async engine. Both tests use a leading SQL comment, verifying positional values and result metadata together.

This PR targets the revert branch in #35 so the previously direct-pushed tests are visible for review. Merge #35 first, then retarget this PR to main.

Validation:

  1. 58 unit tests passed.
  2. The new async join test passed against real D1.
  3. Ruff, formatting, spelling, and pre-commit checks passed for the test changes.

@CollierKing CollierKing closed this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant