Repository navigation
Fix D1 Worker cursor results and add regression coverage - #37
Merged
Merged
Conversation
CollierKing
marked this pull request as ready for review
October 2, 2026 02:13
CollierKing
force-pushed
the
fix/d1-worker-cursor-results
branch
from
October 2, 2026 02:30
050182b to
d0a9fb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Python Worker reads that lose values when columns share a name, or lose column names when a query returns no rows. For example,
SELECT 1 AS id, 7 AS idnow preserves both values and both column names.Builds on @danielalyoshin’s already-merged #33 and #34, which fixed row-returning statement detection and positional REST results.
Changes:
WITH,VALUES, andEXPLAINreads.WITH-prefixed inserts.Validation: