Repository navigation
Conversation
redeboer
commented
Nov 17, 2026
Member
Author
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'TensorWaves benchmark results'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 3f01afb | Previous: d87354f | Ratio |
|---|---|---|---|
benchmarks/expression.py::test_fit[1000-ScipyMinimizer-numpy] |
7.232413942061841 iter/sec (stddev: 0.0008395636109817931) |
16.113062913278878 iter/sec (stddev: 0.0002623519931624775) |
2.23 |
benchmarks/expression.py::test_fit[1000-ScipyMinimizer-numba] |
7.16935485894597 iter/sec (stddev: 0.000611467563372948) |
16.217841898876852 iter/sec (stddev: 0.0003193217998612972) |
2.26 |
benchmarks/expression.py::test_fit[1000-ScipyMinimizer-tf] |
0.6185602969451339 iter/sec (stddev: 0.004700798643981236) |
1.4043607630131383 iter/sec (stddev: 0.0016402295685287915) |
2.27 |
benchmarks/unbinned_nll.py::test_unbinned_nll_normalization_formula[original-numpy] |
28.24288603456473 iter/sec (stddev: 0.0033160427205862464) |
80.89992620132578 iter/sec (stddev: 0.0014910944339774205) |
2.86 |
benchmarks/unbinned_nll.py::test_unbinned_nll_normalization_formula[original-tensorflow] |
59.06725366031111 iter/sec (stddev: 0.0014476197385774605) |
129.63414209598676 iter/sec (stddev: 0.0002041886279346019) |
2.19 |
benchmarks/unbinned_nll.py::test_unbinned_nll_normalization_formula[optimized-numpy] |
36.846555857601054 iter/sec (stddev: 0.0023219141135341374) |
126.61085086393801 iter/sec (stddev: 0.0007772448410810061) |
3.44 |
benchmarks/unbinned_nll.py::test_unbinned_nll_normalization_formula[optimized-tensorflow] |
60.564307458148576 iter/sec (stddev: 0.0019333896871976067) |
160.31611202220606 iter/sec (stddev: 0.0002920427106502862) |
2.65 |
benchmarks/unbinned_nll.py::test_unbinned_nll_estimator[numpy] |
118.81215582460706 iter/sec (stddev: 0.001514530400030229) |
333.18786869068646 iter/sec (stddev: 0.0008835784608970419) |
2.80 |
benchmarks/unbinned_nll.py::test_unbinned_nll_estimator[numba] |
95.73682794608564 iter/sec (stddev: 0.0015552887862024267) |
534.0952050682405 iter/sec (stddev: 0.0009391258569386208) |
5.58 |
This comment was automatically generated by workflow using github-action-benchmark.
redeboer
force-pushed
the
support-phasespace-2
branch
from
November 18, 2026 09:23
27aea40 to
20851d7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phasespacev2.0 #605🐛 Bug fixes
TFPhaseSpaceGeneratorandTFWeightedPhaseSpaceGeneratorwork withphasespace2.0. They now select thephasespacebackend explicitly instead of relying on its default, which became NumPy in 2.0. With the default"tensorflow"backend, the generators produce exactly the same samples for the same seed as before.phasespace1.x keeps working for the TensorFlow backend.⚙️ Enhancements
backendargument that accepts"tensorflow"(default),"numpy", or"jax". NumPy and JAX requirephasespace2.0. The generators always return NumPy arrays.RealNumberGenerator, instead of raising aTypeErrorfor anything other than aTFUniformRealNumberGenerator. A generator that does not belong to the selected backend provides an integer seed, so samples stay reproducible.This PR extracts the non-breaking part of #599 for a 0.4.18 patch release. The
phspextra still installs TensorFlow, and the class names keep theirTFprefix.📝 Documentation
RealNumberGenerator.Squash commit messages