N°9134 - Detect extension with no code when installing by data feature removal extension

[Lenaick]

No description provided.

[Copilot]

Pull request overview

Adds detection of code-less extensions during data-feature-removal compilation.

Changes:

• Introduces a missing-code sentinel across UI and compilation flows.
• Updates extension validation and selection logic.
• Adds a compilation test data set.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
RunTimeEnvironmentTest.php	Tests compilation validity checks.
ExtensionDetails.php	Maps empty extension codes for form submission.
runtimeenv.class.inc.php	Maps selected sentinel codes during compilation.
itopextension.class.inc.php	Defines and validates the missing-code sentinel.
DataFeatureRemovalController.php	Processes sentinel codes from UI selections.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[greptile-apps]

Greptile Summary

The PR introduces a shared sentinel for extensions without a code and propagates it through data-feature-removal selection, UI toggles, runtime compilation, and tests.

• Adds iTopExtension::CODE_NO_CODE and updates code-presence checks.
• Normalizes empty extension codes in the removal controller, extension toggles, and runtime selection.
• Parameterizes runtime compilation coverage for empty and sentinel extension-code inputs.

Confidence Score: 4/5

The PR is not yet safe to merge because removing an installed extension with an empty code still leaves that extension active.

The controller records the removal under no_code, but the runtime passes that identifier unchanged to an extension map keyed by the extension's original empty code; the previously reported removal failure therefore remains outstanding.

Files Needing Attention: datamodels/2.x/combodo-data-feature-removal/src/Controller/DataFeatureRemovalController.php, setup/runtimeenv.class.inc.php

Important Files Changed

Filename	Overview
datamodels/2.x/combodo-data-feature-removal/src/Controller/DataFeatureRemovalController.php	Normalizes empty extension identifiers to the new sentinel while processing UI selection differences.
setup/itopextension.class.inc.php	Defines the shared no-code sentinel and treats it as an absent extension code.
setup/runtimeenv.class.inc.php	Uses the sentinel when matching selected extension codes during compilation.
sources/Application/UI/Base/Layout/Extension/ExtensionDetails.php	Uses the sentinel as the form key for extensions whose code is empty.
tests/php-unit-tests/unitary-tests/setup/RunTimeEnvironmentTest.php	Exercises compilation validity checks with both empty and sentinel extension-code inputs.

_{Reviews (2): Last reviewed commit: "N°9134 - Detect extension with no code w..." | Re-trigger Greptile}