Skip to content

fix: migrate resume draft prompt to shared Dialog - #2049

Open
woahwhattheheck wants to merge 7 commits into
Commitlabs-Org:masterfrom
woahwhattheheck:sol56/commitlabs1921-resume-draft-dialog-20261006
Open

woahwhattheheck wants to merge 7 commits into
Commitlabs-Org:masterfrom
woahwhattheheck:sol56/commitlabs1921-resume-draft-dialog-20261006

Conversation

@woahwhattheheck

@woahwhattheheck woahwhattheheck commented Oct 6, 2026 •

Copy link
Copy Markdown

Closes #1921

Summary

  • rebuild ResumeDraftPrompt on the shared Dialog primitive for ARIA semantics, focus trapping/restoration, initial focus, and Escape handling
  • keep destructive dismissal explicit: shared Dialog supports closeOnBackdrop (default true), while the resume prompt opts out so outside clicks cannot clear saved drafts
  • align the prompt with the dark UI and type commitment icons as Record<string, LucideIcon>
  • wire the existing named-draft persistence API into /create: show allDrafts, resume/delete by id, Start Fresh clears all drafts, autosave keeps one stable active draft id, and successful submission clears only that active draft
  • remove the malformed duplicate handleFundLater tail encountered on the current carrier
  • keep the maintained duplicate-prefill page test aligned with the named-draft persistence API so its happy-dom render path supplies the helpers the repaired page dereferences

Scope / validation

  • exact current head: 6dc67cb1c4291863742bef5c2ca889babc446680
  • 7 commits / 5 files / +190 -111
  • tests/components/Dialog.test.ts pins backdrop opt-out/Escape independence plus the create-page named-draft wiring
  • src/app/create/DuplicateCommitment.test.tsx now mocks allDrafts, clearAllDrafts, and resumeDraft alongside the existing draft helpers, matching the current page contract
  • current-head hosted workflows (Format Check, Lighthouse CI, Typecheck, Circular Dependencies, Dead Code Scan, CodeQL Analysis, Size Limit, Security Audit, Coverage Check) are action_required; no hosted-CI or full-suite green claim is made
  • repository CI and maintainer review remain authoritative

@vercel

vercel Bot commented Oct 6, 2026

Copy link
Copy Markdown

@woahwhattheheck is attempting to deploy a commit to the 1nonly's projects Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResumeDraftPrompt.tsx is a hand-rolled full-screen dialog with no ARIA role, focus trap, or Escape handling

1 participant