Repository navigation
fix: migrate resume draft prompt to shared Dialog - #2049
Open
woahwhattheheck wants to merge 7 commits into
Open
woahwhattheheck wants to merge 7 commits into
woahwhattheheck wants to merge 7 commits into
Conversation
|
@woahwhattheheck is attempting to deploy a commit to the 1nonly's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1921
Summary
ResumeDraftPrompton the sharedDialogprimitive for ARIA semantics, focus trapping/restoration, initial focus, and Escape handlingDialogsupportscloseOnBackdrop(defaulttrue), while the resume prompt opts out so outside clicks cannot clear saved draftsRecord<string, LucideIcon>/create: showallDrafts, resume/delete by id, Start Fresh clears all drafts, autosave keeps one stable active draft id, and successful submission clears only that active drafthandleFundLatertail encountered on the current carrierScope / validation
6dc67cb1c4291863742bef5c2ca889babc446680tests/components/Dialog.test.tspins backdrop opt-out/Escape independence plus the create-page named-draft wiringsrc/app/create/DuplicateCommitment.test.tsxnow mocksallDrafts,clearAllDrafts, andresumeDraftalongside the existing draft helpers, matching the current page contractaction_required; no hosted-CI or full-suite green claim is made