Skip to content

test(validation): consolidate public validation coverage - #2052

Open
woahwhattheheck wants to merge 2 commits into
Commitlabs-Org:masterfrom
woahwhattheheck:sol56/commitlabs1946-validation-consolidation-20261006
Open

woahwhattheheck wants to merge 2 commits into
Commitlabs-Org:masterfrom
woahwhattheheck:sol56/commitlabs1946-validation-consolidation-20261006

Conversation

@woahwhattheheck

Copy link
Copy Markdown

Closes #1946

Summary

  • keep the current single canonical validation suite at src/lib/backend/validation.test.ts
  • cover the remaining public validateCommitmentId path, including the configured length boundary and unsafe identifiers
  • exercise the exported Stellar public-key regex alongside the existing asset/address coverage
  • repair the current-base SUPPORTED_ASSETS[].includes(...) parse defect so the validation module imports cleanly

The older duplicate test path referenced by the issue is already absent on current master; this PR completes the remaining acceptance gap against the repository as it exists now.

Scope

Two files only: the canonical validation test file and the one-character production parse repair. No API behavior redesign or broad test expansion.

@vercel

vercel Bot commented Oct 6, 2026

Copy link
Copy Markdown

@woahwhattheheck is attempting to deploy a commit to the 1nonly's projects Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate validation.ts test suite exists in both src/lib/backend/__tests__ and tests/lib/backend

1 participant