Repository navigation
fix(security): timing-safe seed secret comparison + fix SAMPLE_DATA attestation shape - #2053
Open
neverm1ndthat wants to merge 1 commit into
Open
neverm1ndthat wants to merge 1 commit into
neverm1ndthat wants to merge 1 commit into
Conversation
…ttestation shape Issue Commitlabs-Org#1940: (1) Replace plain === secret comparison with Node's timingSafeEqual (2) Remove non-existent address field from SAMPLE_DATA attestations (3) Add satisfies MockData assertion so shape mismatches are caught at compile time
|
@neverm1ndthat is attempting to deploy a commit to the 1nonly's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1940
Changes
Security fix: isSeedSecretValid() now uses Node's imingSafeEqual instead of plain === comparison, preventing timing side-channel attacks on the seed secret. Follows the same pattern already used in csrf.ts's safeEqualToken helper.
Type shape fix: Removed the non-existent �ddress field from SAMPLE_DATA.attestations[0]. The Attestation interface only defines id, commitmentId, kind, status, �erdict, observedAt, imestamp, severity, and a few optional fields.
Compile-time safety: Added satisfies MockData assertion on SAMPLE_DATA so future shape mismatches are caught at compile time instead of silently passing.