Repository navigation
fix(idempotency): prevent setInterval leakage across Next.js HMR (#1942) - #2054
Open
neverm1ndthat wants to merge 1 commit into
Open
neverm1ndthat wants to merge 1 commit into
neverm1ndthat wants to merge 1 commit into
Conversation
Commitlabs-Org#1942) Use Symbol.for()-keyed global reference so the cleanup interval survives module hot-reload cycles. Previously the module-level 'let cleanupIntervalId' binding would reset to null on each HMR tick, causing a new setInterval to be registered every reload.
|
@neverm1ndthat is attempting to deploy a commit to the 1nonly's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #1942: Module-level setInterval in src/lib/backend/idempotency.ts is never cleared
The Bug
The cleanup setInterval was guarded by a module-level let cleanupIntervalId === null check. In Next.js App Router with module hot-reload (HMR), the module scope is recreated on every file change - so cleanupIntervalId would reset to
ull and a brand-new interval would be registered every HMR cycle, while the old ones leaked forever.
The Fix
Replace the module-scoped let binding with a Symbol.for()-keyed reference on globalThis. This persists across HMR boundaries:
s const CLEANUP_INTERVAL_KEY = Symbol.for('commitlabs.idempotency.cleanupInterval'); declare global { var [CLEANUP_INTERVAL_KEY]?: ReturnType<typeof setInterval>; } if (typeof setInterval !== 'undefined' && typeof globalThis[CLEANUP_INTERVAL_KEY] === 'undefined') { globalThis[CLEANUP_INTERVAL_KEY] = setInterval(() => globalStore.cleanup(), 60_000); }The existing clearCleanupInterval() export is preserved and now correctly reads from the global reference.