Audit follow-ups from Codex review of #21/#22; bump to 1.5.8 - #25
Merged
Merged
Conversation
- WSL discovery defaults off, as the disclosure says; the onboarding prompt still offers it. - Archive: rows matching the credential predicate are invisible to list/grep/restore even when archived before the exclusion existed; `archive status` purges them and reports the count. - SKILL.md: SSH transfers disclosed explicitly (scanner upload, scan output / counters / transcripts download); coverage-limits row; removal instructions include a custom archive.path; Network Boundary row corrected. - discovery.md: the auth.json check snippet prints identifiable claims only when the identifiable opt-in is set. - templates/manifest.example.json: capture_prompts and package_paths keys. - CLAW_HUB_PUBLISHING.md: audit response for 1.5.7 -> 1.5.8. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUhGzUwi8pXjngqs22ghZ3
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd795b49af
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
CompleteDotTech
added a commit
that referenced
this pull request
Sep 10, 2026
… after purge, legacy WSL default withdrawn, dedicated archive directory - ledger_archive: purge_credential_rows removes the stored file in either storage mode and drops the index row only once the file is confirmed gone (unremovable rows are kept and counted); `archive status` purges first and reports the post-purge snapshot; the archive directory must be dedicated (a non-empty directory without the marker is refused; new ones get .ai-usage-ledger-archive). - ledger.py: CONFIG_VERSION 2; a config written before 1.5.8 whose detect.wsl was the old implicit default is migrated to off unless detect.explicit records an operator choice (set by --set / the onboarding answer); onboarding refuses an archive.path that already holds other files. - SKILL.md removal row explains why deleting the archive directory is safe. - tests: check_followups_1_5_9. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUhGzUwi8pXjngqs22ghZ3
3 tasks
Contributor
Author
CompleteDotTech
added a commit
that referenced
this pull request
Sep 10, 2026
Codex follow-ups on #25 (1.5.9): safe credential purge, post-purge status, legacy WSL default withdrawn, dedicated archive directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex reviewed #21 and #22 after they merged. Two of its points were already resolved by #23 (prompt capture opt-in, credential-file skip in the generic sniffer); the rest are fixed here, and the skill moves to 1.5.8 covering issues #11 to #20.
detect.wsldefaults to false; the onboarding prompt still offers itArchive.list()(used by grep and restore) hides rows matching the credential predicate;archive statuspurges them and reports the countarchive.pathidentifiableis setAlso:
templates/manifest.example.jsongainscapture_promptsandpackage_paths;CLAW_HUB_PUBLISHING.mdrecords the 1.5.7 audit response.Test plan
python scripts/validate_quality.py --skip-mermaidpasses (fixtures, store, security suites)n🤖 Generated with Claude Code
https://claude.ai/code/session_01WUhGzUwi8pXjngqs22ghZ3