Codex follow-ups on #27 (1.5.11): reconcile version-2 homes, keep consent when nothing was pruned, full legacy schema check, encoded SQLite URIs - #28
Conversation
…sent when nothing was pruned, full legacy schema check, encoded SQLite URIs - ledger: CONFIG_VERSION 3; on load, when WSL discovery is off the manifest is pruned of WSL hosts whatever version wrote the home, and a scheduled consent is set aside only when that pruning actually changed the scanned scope. - ledger_archive: a legacy archive is accepted only with the complete files and runs schemas; the index path is percent-encoded before it becomes a SQLite URI (also in ledger_query). - tests: version-2 home reconciled, consent kept when no WSL host existed, partial schema refused. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUhGzUwi8pXjngqs22ghZ3
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0dedd306cb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…liation is retried - _is_legacy_archive checks sqlite_master for `files` and `runs` being tables, not views - when the manifest cannot be inspected during reconciliation the home stays at version 2 so the next load retries - tests: runs-view refused, failed reconcile retried after the manifest is repaired Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUhGzUwi8pXjngqs22ghZ3
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3963dcd97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…tion pending Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WUhGzUwi8pXjngqs22ghZ3
1 participant
Summary
Codex reviewed #27 after it merged; all four points fixed.
files/runstables?,#)Test plan
check_followups_1_5_9extended: version-2 home reconciled (WSL hosts pruned, consent set aside, version 3), consent kept when the manifest had no WSL host, partial schema refusedpython scripts/validate_quality.py --skip-mermaidpasses🤖 Generated with Claude Code
https://claude.ai/code/session_01WUhGzUwi8pXjngqs22ghZ3