Skip to content

Attempt to make canceled events not ping - #119

Open
rmamet wants to merge 3 commits into
ComputerScienceHouse:mainfrom
rmamet:patch-1
Open

rmamet wants to merge 3 commits into
ComputerScienceHouse:mainfrom
rmamet:patch-1

Conversation

@rmamet

@rmamet rmamet commented Oct 19, 2026

Copy link
Copy Markdown

What

It should make it so events with [CANCELLED] in their title send a message, but don't ping.

Why

#118 and also mentioned in House Meeting

Test Plan

image

@datadog-computersciencehouse

datadog-computersciencehouse Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Pipelines

⚠️ Warnings

Your PR has warnings. Please review the issues below.

🚦 1 Pipeline job failed

Sonarqube | Build and analyze

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 448797d | Docs | View more details | Give us feedback!

@pikachu0542 pikachu0542 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should ensure this feature works correctly for "cancelled" or "canceled", bc both of those are correct spellings, and i have seen both used on the calendar

@pikachu0542 pikachu0542 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the sonarqube issues?

or whatever its called... too lazy to check spelling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants