Skip to content

fix(docs): skip the docs deploy on pushes to the template itself - #191

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/template-docs-skip-deploy
Sep 28, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
fix/template-docs-skip-deploy

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Why

The guard from #190 worked. Run 36390914494 skipped the Cloudflare publish with an empty CF_API_TOKEN, and app-template.conduction.nl has no DNS record. The shared workflow's next step, "Verify the LIVE site serves this build", then failed the run, because it treats every skipped publish as an error. That is right for a real app. In the template it means every docs push goes red.

What changed

In the template, pushes now skip the documentation job:

if: ${{ !github.event.repository.is_template || github.event_name == 'pull_request' }}
  • Template, pull request: the job runs. The shared workflow only builds and validates on a pull request, so the template's docs stay checked.
  • Template, push: the job is skipped, so nothing publishes and no red.
  • Scaffolded app: not a template, so every push runs as before.

The secrets guard stays as a second line of defence.

Verified

  • actionlint 1.7.7 passes.
  • The pull-request path is exercised by this PR's own run.
  • The push path can only be checked after merge: the Documentation run on development should show the job skipped.

🤖 Generated with Claude Code

After #190 the secrets guard worked: run 36390914494 skipped the
Cloudflare publish and no app-template.conduction.nl record exists. But
the shared workflow's "Verify the LIVE site" step then failed the run,
as it does for any skipped publish, so every docs push to the template
went red.

In the template, pushes now skip the job. Pull requests still run it,
and there the shared workflow only builds and validates. Scaffolded apps
are not templates, so they run every push as before. The secrets guard
stays as a second line of defence.
@rubenvdlinde
rubenvdlinde merged commit 910c7bb into development Sep 28, 2026
45 of 46 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/nextcloud-app-template @ 0df4a4d

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-specs ✅
check-manifest ✅
format ✅
composer ✅ ✅ 103/103
npm ✅ ✅ 737/737
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ✅
Newman ✅
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test.
Hydra gates ❌

Quality workflow — 2026-09-28 07:30 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant