fix(chrome): give the template the Store, Reports and Flows entries gate-107 requires - #192
Merged
Merged
Conversation
…7 bump Gate-107 passes locally; full hydra-gates suite exit 0; check:manifest, check:specs, check:l10n-js, lint, stylelint, format and l10n-parity pass. Open: npm run build hit a 600s timeout on the second run (passed on the first), and the e2e count changes (9 pages, 6 nav icons) are unverified until CI runs Playwright.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 28, 2026 11:37
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 103/103 | |||
| npm | ✅ | ✅ 857/857 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-28 11:40 UTC
Download the full PDF report from the workflow artifacts.
This was referenced Sep 28, 2026
rubenvdlinde
added a commit
that referenced
this pull request
Sep 28, 2026
…ships the skip check (#193) The two remaining E2E reds on development, both found by a manual run of Code Quality (36438054845), the only way to reach Playwright outside the promotion path. - FeaturesRoadmap-chromium-linux.png is CI's own render from that run. The page gained the Store and Reports footer entries (#192), and the right-hand panel reflows under nextcloud-vue 2.57. Both attempts rendered byte-identical images. - conduction/hydra-gates ^1.0 locked v1.9.0, which predates check_e2e_skips.py (added 2026-08-24), so the skip-discipline step failed with 'not found'. ^1.18.0 ships it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
developmenthas been red onquality / Hydra Gates(and so onQuality Report) every night. The only failing gate is gate-107, app-chrome (ADR-114): the template declared Documentation and Features & roadmap, but not Store, Reports or Flows. All five became blocking once the Store and Reports rollouts landed in the fleet, so the template was the one repo left behind. Every new app inherits whatever the template ships.What changed
type: "store", footer, order 92), Reports (type: "reports", footer, order 95) with one Examples report built fromstatwidgets, and Flows in the settings section. Flows uses the current shape: atype: "index"list overentitySource: "flows"plus atype: "flow"editor, not the deprecatedflows/flow-detailpage types.ChartBoxOutline,CheckCircleOutline,SitemapandStoreOutlineregistered insrc/icons.js(gate-60).@conduction/nextcloud-vue^2.16.0 to ^2.57.1 (resolves 2.57.2), the version the fleet runs. The new page types need it. Its optional stylelint peer forcedstylelint15 to 17 and@nextcloud/stylelint-config2.4 to 3.2.2, again matching the fleet. The lockfile was resolved with npm 11, whichenginesrequires. Supersedes chore(deps): refresh the shared Conduction locks #188.app-shell.spec.tsnow expects 9 manifest pages and 6 painted nav icons, and checks that the new pages render without a "Widget unavailable" placeholder.Verified locally
check:manifest,check:specs,check:l10n-js,lint,stylelint,formatandtests/l10n/check-l10n-parity.jsall pass.npm ci(npm 11) andnpm run buildpass.Not verified locally
Playwright needs a running Nextcloud, so this PR's CI run is the first test of the new counts. The icon count of 6 assumes the settings foldout is collapsed on load, so Flows paints no icon. If CI shows 7, the count is what needs fixing.
Inherited, not fixed: the dashboard's "In progress" and "Closed" tiles count every example, because neither filters on status.
🤖 Generated with Claude Code