Skip to content

fix(chrome): give the template the Store, Reports and Flows entries gate-107 requires - #192

Merged
rubenvdlinde merged 1 commit into
developmentfrom
fix/app-chrome-adr-114
Sep 28, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
fix/app-chrome-adr-114

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Why

development has been red on quality / Hydra Gates (and so on Quality Report) every night. The only failing gate is gate-107, app-chrome (ADR-114): the template declared Documentation and Features & roadmap, but not Store, Reports or Flows. All five became blocking once the Store and Reports rollouts landed in the fleet, so the template was the one repo left behind. Every new app inherits whatever the template ships.

What changed

  • Manifest. Store (type: "store", footer, order 92), Reports (type: "reports", footer, order 95) with one Examples report built from stat widgets, and Flows in the settings section. Flows uses the current shape: a type: "index" list over entitySource: "flows" plus a type: "flow" editor, not the deprecated flows / flow-detail page types.
  • Icons. ChartBoxOutline, CheckCircleOutline, Sitemap and StoreOutline registered in src/icons.js (gate-60).
  • Dependencies. @conduction/nextcloud-vue ^2.16.0 to ^2.57.1 (resolves 2.57.2), the version the fleet runs. The new page types need it. Its optional stylelint peer forced stylelint 15 to 17 and @nextcloud/stylelint-config 2.4 to 3.2.2, again matching the fleet. The lockfile was resolved with npm 11, which engines requires. Supersedes chore(deps): refresh the shared Conduction locks #188.
  • Translations. Four new keys (Store, Reports, Flows, Flow) in all 37 catalogues, taken from the fleet apps' existing translations. The report reuses the existing "Examples" and "Closed" keys.
  • e2e. app-shell.spec.ts now expects 9 manifest pages and 6 painted nav icons, and checks that the new pages render without a "Widget unavailable" placeholder.

Verified locally

  • Full Hydra gate suite: exit 0, 78 of 78 applicable gates ran, no failures. Gate-107 reports 5 of 5 chrome items.
  • check:manifest, check:specs, check:l10n-js, lint, stylelint, format and tests/l10n/check-l10n-parity.js all pass.
  • npm ci (npm 11) and npm run build pass.

Not verified locally

Playwright needs a running Nextcloud, so this PR's CI run is the first test of the new counts. The icon count of 6 assumes the settings foldout is collapsed on load, so Flows paints no icon. If CI shows 7, the count is what needs fixing.

Inherited, not fixed: the dashboard's "In progress" and "Closed" tiles count every example, because neither filters on status.

🤖 Generated with Claude Code

…7 bump

Gate-107 passes locally; full hydra-gates suite exit 0; check:manifest,
check:specs, check:l10n-js, lint, stylelint, format and l10n-parity pass.
Open: npm run build hit a 600s timeout on the second run (passed on the
first), and the e2e count changes (9 pages, 6 nav icons) are unverified
until CI runs Playwright.
@rubenvdlinde
rubenvdlinde merged commit 7c0d65c into development Sep 28, 2026
51 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/nextcloud-app-template @ 5eb64ae

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-specs ✅
check-manifest ✅
format ✅
composer ✅ ✅ 103/103
npm ✅ ✅ 857/857
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ✅
Newman ✅
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test.
Hydra gates ✅

Quality workflow — 2026-09-28 11:40 UTC

Download the full PDF report from the workflow artifacts.

rubenvdlinde added a commit that referenced this pull request Sep 28, 2026
…ships the skip check (#193)

The two remaining E2E reds on development, both found by a manual run of
Code Quality (36438054845), the only way to reach Playwright outside the
promotion path.

- FeaturesRoadmap-chromium-linux.png is CI's own render from that run.
  The page gained the Store and Reports footer entries (#192), and the
  right-hand panel reflows under nextcloud-vue 2.57. Both attempts
  rendered byte-identical images.
- conduction/hydra-gates ^1.0 locked v1.9.0, which predates
  check_e2e_skips.py (added 2026-08-24), so the skip-discipline step
  failed with 'not found'. ^1.18.0 ships it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant