Repository navigation
fix(example-sets): a set may require a register OpenRegister ships only as a mock - #4658
Merged
rubenvdlinde merged 2 commits intoOct 15, 2026
Merged
Conversation
…ly as a mock
A fresh instance refused the zuiddrecht set: brp and kvk are mock-only
descriptors, and the real-configuration re-import correctly refuses a mock.
A requires entry now names the descriptor it wants: a slug for the real
one, {"register": "<slug>", "mock": true} for the mock, imported through
reimportMock() under openregister.mock and recorded for remove as before.
A plain slug never falls back to the mock. zuiddrecht declares brp and kvk
as mock requirements.
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ✅ | ||||
| test-l10n-parity | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 173/173 | |||
| npm | ✅ | ✅ 648/648 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ 26202/26202 · 25 skipped | ||||
| Newman | ✅ 714/714 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-10-15 19:10 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh-instance rehearsal of the Zuiddrecht demo refused 15 items:
register "brp" is required and could not be imported from OpenRegister's descriptor: ... declares no register "brp".brpandkvkship only as mock descriptors (x-openregister.type: mock), and since #4618 the real-configuration re-import correctly refuses a mock.example-set:installhad no way to ask for the mock, so a nightly remove + install on a reset instance would fail every night.Change
requiresentry in a cast file is either a slug (imported from the real descriptor, as before) or{"register": "<slug>", "mock": true}, imported throughRegisterDescriptorService::reimportMock()underopenregister.mock. The import jobs are recorded and removed exactly as before.zuiddrecht.jsondeclaresbrpandkvkas mock requirements.--mockflag onexample-set:install: the set declares what it needs, so the nightly reset and a hand install run the same command.example-setsamended with two scenarios, decision 7 in design.md amended, task 3.13.Verified
ExampleSetMockRegisterImportTestreads the shipped zuiddrecht cast and OpenRegister's ownlib/Settingsthrough the real catalogue,ExampleSetRegistersandRegisterDescriptorService(only the database and the configuration import are fakes): every required register imports on a fresh instance underopenregister.mock. Control: three of its four tests fail on the previouslib/(the fourth pins that a plainbrpis still refused).composer check:strict: lint, phpcs, psalm, phpstan clean; phpmd flagged a boolean flag argument, fixed by splittingimportMock()out (re-checked). The test run has 15 errors inAuditTrail*/DraftRemoval*DB tests fromMigratedSqliteDatabase(no Nextcloud server root in the local tree); untouched by this change. The example-set and descriptor suites are green (125 tests)._rbacadded.Other apps' zuiddrecht fragments do not declare
requires; only the cast file does, so no app PRs are needed.