Repository navigation
Code cleanup and stabilisation - #870
Closed
rubenvdlinde wants to merge 1625 commits into
Closed
rubenvdlinde wants to merge 1625 commits into
rubenvdlinde wants to merge 1625 commits into
Conversation
rubenvdlinde
force-pushed
the
feature/php-linting
branch
6 times, most recently
from
December 21, 2025 09:20
ae8b0ca to
194cb9f
Compare
rubenvdlinde
force-pushed
the
feature/php-linting
branch
5 times, most recently
from
December 29, 2025 08:56
7401d63 to
9a5db95
Compare
rubenvdlinde
force-pushed
the
feature/php-linting
branch
3 times, most recently
from
January 6, 2026 09:13
50ad411 to
35176bf
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
rubenvdlinde
force-pushed
the
feature/php-linting
branch
3 times, most recently
from
February 19, 2026 18:56
e1a8a8b to
8c6ea65
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…locks Fixes 15 PossiblyUndefinedVariable Psalm errors by initializing variables before try/if blocks. Also adds app_api availability check in WorkflowEngineRegistry and improves N8nAdapter docblock. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…sibility Each tool (PHP Lint, PHPCS, PHPMD, Psalm, PHPStan, phpmetrics) now shows as a separate box in the GitHub Actions workflow graph. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…gicMapper support The resolver was calling QueryHandler directly, bypassing the register/schema context setup that ObjectService.buildSearchQuery() provides. This caused list queries to return 0 results for MagicMapper-backed schemas. Also fixes ObjectEntity results not being converted to arrays before GraphQL field resolution.
Used `_rbac:` but addCrudPaths() expects `rbac:` (no underscore).
This caused HTTP 500 on /api/registers/{id}/oas endpoints.
ReadFileHandler referenced $this->unifiedObjectMapper which was never declared as a property (leftover from blob storage removal). This caused a null reference crash when loading /settings/apps. Consolidated duplicate MagicMapper injections ($objectEntityMapper and $objectMapper) into a single $objectMapper parameter and updated all references.
…ests
Spec enrichment:
- All 45 base specs updated with Current Implementation Status,
Standards & References, and Specificity Assessment sections
New specs:
- mock-registers: BRP/KVK/BAG/DSO/ORI register definitions (8 requirements)
- open-raadsinformatie: ORI council information register (10 schemas)
- dso-omgevingsloket: DSO environmental permit register
- larping-skill-widget: base spec synced from archived change
- prometheus-metrics: production-observability spec updated
Mock register data:
- brp_register.json: 35 RVIG test persons with family relationships
- kvk_register.json: 16 KVK test businesses + 14 branches
- bag_register.json: 74 BAG address/building records
- dso_register.json: 53 DSO permit records
- ori_register.json: 115 ORI council records ("Voorbeeldstad")
Implementation:
- MetricsController + HealthController for /api/metrics and /api/health
- BlobMigrationJobTest.php (11 tests)
- 6 handler test files (107 tests, 223 assertions)
- Fixed phpunit-unit.xml to include lib/Db/ in coverage
- Removed MigrationService dead code (blob storage methods)
- Admin settings now expose blob migration progress
- database-tests.yml: PostgreSQL + MariaDB CI matrix
Archived changes:
- larping-skill-usage-widget
- retire-blob-objects-table
The webpack alias was hardcoded to ../nextcloud-vue/src which breaks GitHub CI builds where the local monorepo directory doesn't exist. Now uses fs.existsSync to conditionally alias only when the local source is available, falling back to the published npm package. Also adds deduplication aliases for vue/pinia/@nextcloud/vue.
fix: Conditional @conduction/nextcloud-vue alias with npm fallback
…e/registers-470/update-composer
…e-composer Composer update and other fixes for OpenConnector and OpenCatalogi
…e/nextcloud-vue-package-usage
- Removed npm run dev warnings - Fixed a couple of eslint errors - Removed tooltips from EditSchema that are already set correctly in the Component
…-package Addes small fixes
…ge-usage Merge package to php-linting
Contributor
Author
|
Closing — superseded by newer work or stale (3+ months). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.