Repository navigation
fix(ontology): discard prior evidence when reader scope changes - #1157
seonghobae wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughOntologyExplorer는 reader, focus 또는 cutoff 변경 시 기존 데이터와 선택 상태를 초기화합니다. 이전 요청의 결과와 오류는 현재 뷰에 반영되지 않습니다. 관련 테스트, Storybook 사례, ADR과 기술 기준 문서도 갱신했습니다. ChangesOntologyExplorer 요청 범위 처리
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The change makes the ontology explorer discard earlier evidence when the reader, cutoff or focus changes, and it ignores late responses from the old scope. No concrete merge-blocking problem was found, and tests cover the main cases. Authenticated end-to-end validation was not run. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change reduces stale-evidence exposure when the reader or exploration scope changes. No new security issue was identified in the inspected production path. Caller-supplied data ownership and deployed authorization enforcement remain outside the verified scope. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
1 participant
Reader scope changes now clear the previous graph, selection, page cursor, exports, and nested search before the new reader, focus, or cutoff can render. Request-generation fencing ignores late replies from the prior scope. The branch is synchronized with current main using merge commit
c4bda8c29a41109088d1f9718d588160be3a1801, preserving the independent 401 recovery behavior already on main.Denied 401/403/404 evidence is cleared and offers the appropriate next action. Same-scope transient failures retain authorized pages and allow retry. No API shape, database schema, migration, dependency, release number, model policy, or calculation changed.
Validation on the synchronized code tree: 75 backend ontology/ingestion/cutoff/visibility tests; 74 frontend explorer/layout tests; frontend lint, production build, and Storybook build. Backend tests ran with DeprecationWarning treated as an error. Synthetic denied-scope Storybook rendering was visually inspected at 1440×900 and 390×844; both disable exports and show no graph evidence. Screenshots remain outside git.
GitHub reports four failed Checks on the current head. The run-detail request was rate-limited, so their causes are not claimed here. No current-head independent approval exists. The live rules read exposes only no-force-push protection and no classic branch-protection rules; auto-merge remains unarmed so it cannot bypass the requested review/check gates. Authenticated PostgreSQL/API acceptance, production UI acceptance, and synthetic authenticated k6 capacity evidence remain unavailable.