fix(composition): classify superseded serving snapshots before HTTP projection - #442
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough라우팅 중 복구된 스냅샷과 현재 상태가 일치하지 않으면 Changes라우팅 오류 처리
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The changed routing paths have regression coverage, and no merge-blocking issue was identified. Merge after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review Please review exact head |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
gh api repos/ContextualWisdomLab/Orgmetra/pulls/442 --jq '{head_sha: .head.sha, state: .state, draft: .draft, html_url: .html_url}'
gh api repos/ContextualWisdomLab/Orgmetra/pulls/442/commits --jq '.[-5:] | map({sha: .sha, subject: (.commit.message | split("\n")[0])})'Length of output: 992
|
|
@coderabbitai review Retry exact-head review for |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
gh api repos/ContextualWisdomLab/Orgmetra/pulls/442 --jq '{head_sha: .head.sha, state: .state, draft: .draft, html_url: .html_url}'Length of output: 456
✅ Action performedFull review finished. |
1 participant
Scope
Narrow serving-failure classification child of #440. Current base is #440 exact
0050f14701ea92fd85a2691a280d29c46a97b63band current source head is9bbb792ef43fca8b08684f4f55a8bfe65e1120da, open · Draft · mergeable, ordinary-forward only. This branch owns the typed durable-currentness-to-route-unavailability adapter and changes no SQL/migration bytes, durable state rules, owner schema, authentication, owner HTTP dispatch, deployment packaging or performance evidence.Contract
RED
ee642f086b8d08a14d1a7f9befef9ee490a1baa7requires both selected-route and resource-specific 405 currentness consumers to translate typedActivationConflictErrorintoCompositionRouteUnavailableError, while leavingActivationAuthorizationErrorunwrapped. Repaircd908b65a8047d85e57cb82c0665185c201972b3introduced one_current_route_ids()adapter;d58dc07034082a18a5de6c9f4df03d40b096a72frepaired diff-docstring quality without altering behavior.#437 repaired expiry ambiguity at exact
a09d6fb928e0272673b82ef7353ed83213aa994d.ServingEvidenceExpiredErroris anActivationConflictErrorsubtype used only for otherwise-valid recovery evidence that expires at the PostgreSQL wall-clock linearization point. Clock rewind, malformed durable state, retargeting and authorization/integrity failures remainActivationAuthorizationError. This branch therefore projects expected expiry to ordinary route unavailability without exception-message inspection and does not launder integrity/security failures.The repaired parent authority was adopted ordinary-forward through #438/#439/#440 and then into this branch. No force-push, destructive rebase, SQL change or duplicate owner logic was introduced. PostgreSQL lineage remains 0018→0025.
Descendant lifecycle authority — current
#443 exact
728f07a8c86f92bbf33586f2a8007da9f31f5e06owns bounded inbound ASGI request-body/receive lifecycle. #444 exacte1af671deeeec682dffdf809cb8579dcc4d439daowns core outbound ASGI response-event/send validation. Current response-completion leaf #446 exact7954f5bf606584ddb5bbcd29e1b64e49041b9409prevalidates complete non-streaming responses, enforces no-content/framing/transfer-coding rules and detaches validated caller headers before transport. None of these descendants changes this PR's currentness classification or SQL/migration bytes.Verification boundary
Canonical acceptance uses one unchanged exact #446
7954f5bf606584ddb5bbcd29e1b64e49041b9409composition tree. #447 exact47ac3556dfef7d5d27af2af8ae2ba5038b837e7cis the current Draft #260 Foundation discovery/runtime implementation; it remains non-GREEN pending normal #64/#305 metadata integration plus protected-base checks/review. #261 owns installed wheel/sdist acceptance; #311 exactdbc2fcf70ba6a6883381e8526cd62c6e19ce159cowns the complete inherited 0018→0025 PostgreSQL inventory on the same tree. Source-level typing/stacking, bot status and mergeability are not exact-head runtime GREEN.#440 remains the HTTP projection owner; #437 remains durable currentness owner. Proposed architecture #433 is source-current at
ff50182c25ccf45928b1413f947c992f62be2dedbut ADR 0432 remains Proposed.Keep Draft until same-tree package/install/PostgreSQL execution, prerequisite checks and qualifying independent review exist. No self-approval, routine administrator bypass, gate weakening, synthetic status, feature-local quality workflow, mutable sibling source, cross-service SQL, force-push/destructive rebase, predecessor-GREEN transfer, premature Ready/merge/release or simple Close is authorized.
Refs #432 #433 #437 #438 #439 #440 #443 #444 #446 #447 #260 #261 #311 #100.