build(validity): make execution lane reproducible - #58
seonghobae wants to merge 8 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Validation update for head
PR remains draft and blocked; no independent hosted review is present and required hosted checks are queued. No merge performed. |
|
Current exact PR head is now Fresh verification at |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| try: | ||
| output = run_worker( | ||
| repository=repository, | ||
| design_code=args.design_code, | ||
| rust_device=args.rust_device, | ||
| persons=args.persons, | ||
| items_per_dim=args.items_per_dim, | ||
| clusters=args.clusters, | ||
| seed=args.seed, | ||
| worker_count=args.worker_count, | ||
| timeout_seconds=args.timeout_seconds, | ||
| ) | ||
| finally: | ||
| resolve_revision(repository) |
There was a problem hiding this comment.
📝 Info: Post-run checkout verification is unconditional
main repeats exact-revision and cleanliness checks after worker success or failure. Temporary build paths keep expected artifacts outside the foreign checkout.
Was this helpful? React with 👍 or 👎 to provide feedback.
| occasion_count=2 if args.design_code == "longitudinal" else 1, | ||
| maximum_memberships=2 if args.design_code == "multiple_membership" else 1, | ||
| worker_count=args.worker_count, | ||
| rust_device=args.rust_device, | ||
| ) | ||
| request.require_runnable() | ||
| try: | ||
| output = run_worker( |
There was a problem hiding this comment.
📝 Info: Contract-only designs cannot reach worker
require_runnable rejects multiple-membership and longitudinal requests before run_worker. Their CLI exposure does not silently execute the current estimator.
Was this helpful? React with 👍 or 👎 to provide feedback.
| def build_rust_recovery_evidence( | ||
| request: RustExecutionRequest, | ||
| worker_output: Mapping[str, object], | ||
| *, | ||
| completed_at: datetime, | ||
| ) -> RustRecoveryEvidence: |
There was a problem hiding this comment.
📝 Info: Recovery metrics cannot populate validity results
build_rust_recovery_evidence returns only RustRecoveryEvidence. No path maps recovery errors into criterion-related effect estimates.
Was this helpful? React with 👍 or 👎 to provide feedback.
| if self.design_code == "nested_multilevel": | ||
| if self.cluster_count is None or type(self.cluster_count) is not int or self.cluster_count < 2: | ||
| raise ValueError("nested_multilevel recovery evidence requires cluster_count >= 2") | ||
| if self.cluster_count > self.sample_size: | ||
| raise ValueError("nested_multilevel recovery evidence cluster_count cannot exceed sample_size") | ||
| elif self.cluster_count is not None: | ||
| raise ValueError("cross_sectional recovery evidence cannot carry cluster_count") |
There was a problem hiding this comment.
📝 Info: Cluster invariants match worker output
Nested runs cannot produce more clusters than people, while cross-sectional runs report none. Valid builder output remains accepted under both designs.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Lifecycle authority correction: #58 is now Draft because it remains based on predecessor #57 snapshot |
seonghobae
added
priority: medium
status: draft
type: maintenance
maintenance
labels
ChatGPT Codex Connector
1 participant
Summary
PYTHONPATH.uv runverification command and checkeduv.lock.This remains a stacked preparation PR for #57. It does not claim statistical execution or validity estimation; the pinned fast-mlsirm handoff/result boundary remains human-reviewed scientific evidence only.
Latest child integrity repair
Fresh current-source review verified Devin finding
PRRT_kwDOT5D6WM6dZ9ON: directRustRecoveryEvidenceconstruction accepted cross-sectional receipts carrying cluster metadata, nested receipts with missing/one cluster, and nested receipts with more clusters than people.Regression-only
14f0f08109a134518287024d14b49bb611d7e7fdadds direct-construction tests requiring cross-sectionalcluster_count=None, nested integercluster_count >= 2, andcluster_count <= sample_size. Root repair852b088ee1fdde511ecbfdda6abcbe0dd0b7802echanges only the owningRustRecoveryEvidence.__post_init__boundary so contradictory scientific receipts fail closed before canonical evidence can be issued. The addressed bug thread is resolved.Fresh stack truth — 2026-09-20
6a3e2aa57e3f27a2a2f50ff4072c5634e949a23adevelop@eb9757f8649aaad026a9865508d9aad50c1a7a4fdevelopis unchangede22df241d3ef9a64724c76a434ecd94cdd7fc73freceived a real hosted Foundation RED in run35384159436: 1 of 177 validity-analysis tests failed, 176 passed, and coverage was 99.61%; the failure was in a test helper that dereferenced a hostileobject()before productionWeightVarianceCompatibilityReceipttype validation could run6a3e2aa...minimally repairs that helper so malformed and foreign-tenant candidates reach the existing production guard; production source is unchanged and predecessor verdicts do not transfer35495945337,35495945341,35495945329,35495945399are all still queued at this refresh; exact-head GREEN is not claimed35384159403separately exposed public-repository Dependency Review HTTP 403 fail-closed behavior; central owner tracking is.github#81035384159492separately failed closed withVERDICT_STATE=pending; central owner tracking is.github#1929APPROVEDreview; visible review threads are resolved or outdated+resolved852b088ee1fdde511ecbfdda6abcbe0dd0b7802efeat/validation-analysis-handoff@081942a723c2ae2cb9bb98a8ffd0b33b72a8bd74The child therefore does not include current #57 scientific contracts or evidence. Parent checks/reviews do not transfer, and current-parent workflow identities are not acceptance evidence for this stale descendant.
Stack discipline
Process #57 dependency-first. Do not restack this descendant while #57 remains unintegrated merely to manufacture current-parent evidence. After #57 integrates normally into then-current protected
develop, reconcile this existing child branch non-force, preserve its valid Rust-recovery/uv delta, refetch exact head/base/conflict state, rerun the full validity-analysis suite with exact owned statement/branch coverage plus every applicable central gate, and obtain qualifying independent non-author review without transferring predecessor or parent evidence.Do not self-approve, use routine administrator bypass, weaken a gate, mutate
fast-mlsirmor another dedicated-writer repository, or treat absent/cancelled/stale/predecessor evidence as passing.