Skip to content

preserve(ui): duplicate Settings/Help tooltips pending #1193 - #1250

Draft
seonghobae wants to merge 2 commits into
developfrom
palette-accessible-tooltips-13376885060406650359
Draft

seonghobae wants to merge 2 commits into
developfrom
palette-accessible-tooltips-13376885060406650359

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

Preservation / single-writer status

이 PR은 Open / Draft / mergeable preservation lane입니다. App.tsx의 unavailable-control Tooltip 독립 owner로 병합하지 않습니다.

  • Protected base: develop@314ddeae7b775a4957594b599358c8255617eb2e
  • Exact current head: 4a6f8eac8c025211d03211b08701b7b9f138d474
  • Fresh compare: ahead=2 / behind=0, merge base exactly protected develop
  • Current diff: apps/desktop/src/App.tsx 한 파일만 남습니다.

Canonical owner

Canonical App unavailable-control Tooltip owner는 #1193 exact ba88931e076161341381c3c16ebaa1e50a5bf1d0입니다. #1193은 이미 Settings/Help에 shared Base UI Tooltip을 적용하면서 focusable aria-disabled, localized accessible name, activation guard를 보존하고 있습니다. 같은 owner tree에서 Import/Export, YouTube clear, unavailable Save, shared Tooltip viewport/reduced-motion resilience, persistent aria-describedby prerequisite reason과 focused regression까지 함께 관리합니다.

따라서 이 branch의 Settings/Help title → Tooltip 교체는 #1193의 유효 semantic delta에 이미 포함되어 있으며, 별도 writer로 병합하면 같은 App.tsx authority를 다시 분기합니다.

이 branch가 추가한 aria-disabled:opacity-50 / 중복 aria-disabled:cursor-not-allowed styling은 canonical contract로 자동 승계하지 않습니다. 기존 #1193 control은 이미 unavailable state를 시각적으로 표현하고 있으며, 추가 opacity가 실제 contrast/readability를 개선한다는 browser/accessibility evidence가 없습니다. Styling 변경은 별도 buyer-visible evidence 없이 canonical accessibility contract보다 우선하지 않습니다.

Repair performed here

Generated branch에 제품 변경과 무관한 dev_output.log가 포함되어 있었습니다. Exact predecessor 65225732...에서 해당 파일은 로컬 Vite 개발 서버 출력(Local: http://localhost:5173/)만 담고 있었습니다. Commit 4a6f8eac8c025211d03211b08701b7b9f138d474에서 이 artifact를 제거해 현재 diff를 App Tooltip delta 하나로 제한했습니다.

CodeRabbit이 dev_output.log를 path filter로 무시했다는 사실은 artifact가 repository product delta였다는 근거가 아닙니다. 로컬 실행 출력은 source/fixture/contract/evidence로 보존하지 않습니다.

PR-0 / succession rule

이 PR은 #1193이 protected truth가 되기 전 단순 Close하지 않습니다. #1193이 prerequisites를 정상 통합하고 ordinary/non-force reconciliation 후 current-head repository/central gates, browser/a11y evidence, qualifying independent non-author approval을 획득해 Settings/Help delta의 protected succession이 검증되면 unmerged closure를 판단합니다.

No self-approval, force-push, destructive rebase, gate weakening, synthetic status, no-op freshness commit, blind rerun, predecessor-evidence transfer, or duplicate App.tsx source ownership.

Replaced the native HTML `title` attributes on the "Settings" and "Help" buttons with custom `Tooltip` components from `@/components/ui/tooltip` for improved accessibility and UX on disabled buttons. Added required aria-disabled visual classes.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 456d2fdc-c7a7-41fc-8970-f2f0d2a4635c

📥 Commits

Reviewing files that changed from the base of the PR and between 314ddea and 6522573.

⛔ Files ignored due to path filters (1)
  • dev_output.log is excluded by !**/*.log
📒 Files selected for processing (1)
  • apps/desktop/src/App.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

사이드바 하단의 비활성 설정 및 도움말 버튼이 title 속성 대신 Tooltip 구성 요소로 안내 메시지를 표시합니다. 접근성 속성과 비활성 동작은 유지됩니다.

Changes

사이드바 툴팁

Layer / File(s) Summary
비활성 버튼 툴팁 연결
apps/desktop/src/App.tsx
Tooltip, TooltipContent, TooltipTrigger를 추가했습니다. 설정 및 도움말 버튼을 각각 TooltipTrigger로 감싸고 안내 메시지를 TooltipContent로 표시합니다. aria-label, aria-disabled, preventUnavailableAction, cursor-not-allowed는 유지됩니다.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 4a6f8

The disabled Settings and Help buttons retain their accessibility labels and click prevention while showing the intended tooltip messages. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 Settings 및 Help 버튼의 툴팁 변경을 나타내며 변경 내용과 관련됩니다. 다만 접근성 개선 목적은 명시하지 않습니다.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as draft September 21, 2026 14:32
@seonghobae seonghobae changed the title 🎨 Palette: 접근성 있는 툴팁 적용 preserve(ui): duplicate Settings/Help tooltips pending #1193 Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant