preserve(ui): duplicate Settings/Help tooltips pending #1193 - #1250
seonghobae wants to merge 2 commits into
Conversation
Replaced the native HTML `title` attributes on the "Settings" and "Help" buttons with custom `Tooltip` components from `@/components/ui/tooltip` for improved accessibility and UX on disabled buttons. Added required aria-disabled visual classes.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough사이드바 하단의 비활성 설정 및 도움말 버튼이 Changes사이드바 툴팁
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Feature Merge Risk: ⚪ Minimal · up to The disabled Settings and Help buttons retain their accessibility labels and click prevention while showing the intended tooltip messages. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Preservation / single-writer status
이 PR은 Open / Draft / mergeable preservation lane입니다.
App.tsx의 unavailable-control Tooltip 독립 owner로 병합하지 않습니다.develop@314ddeae7b775a4957594b599358c8255617eb2e4a6f8eac8c025211d03211b08701b7b9f138d474ahead=2 / behind=0, merge base exactly protecteddevelopapps/desktop/src/App.tsx한 파일만 남습니다.Canonical owner
Canonical App unavailable-control Tooltip owner는 #1193 exact
ba88931e076161341381c3c16ebaa1e50a5bf1d0입니다. #1193은 이미 Settings/Help에 shared Base UI Tooltip을 적용하면서 focusablearia-disabled, localized accessible name, activation guard를 보존하고 있습니다. 같은 owner tree에서 Import/Export, YouTube clear, unavailable Save, shared Tooltip viewport/reduced-motion resilience, persistentaria-describedbyprerequisite reason과 focused regression까지 함께 관리합니다.따라서 이 branch의 Settings/Help
title→ Tooltip 교체는 #1193의 유효 semantic delta에 이미 포함되어 있으며, 별도 writer로 병합하면 같은App.tsxauthority를 다시 분기합니다.이 branch가 추가한
aria-disabled:opacity-50/ 중복aria-disabled:cursor-not-allowedstyling은 canonical contract로 자동 승계하지 않습니다. 기존 #1193 control은 이미 unavailable state를 시각적으로 표현하고 있으며, 추가 opacity가 실제 contrast/readability를 개선한다는 browser/accessibility evidence가 없습니다. Styling 변경은 별도 buyer-visible evidence 없이 canonical accessibility contract보다 우선하지 않습니다.Repair performed here
Generated branch에 제품 변경과 무관한
dev_output.log가 포함되어 있었습니다. Exact predecessor65225732...에서 해당 파일은 로컬 Vite 개발 서버 출력(Local: http://localhost:5173/)만 담고 있었습니다. Commit4a6f8eac8c025211d03211b08701b7b9f138d474에서 이 artifact를 제거해 현재 diff를 App Tooltip delta 하나로 제한했습니다.CodeRabbit이
dev_output.log를 path filter로 무시했다는 사실은 artifact가 repository product delta였다는 근거가 아닙니다. 로컬 실행 출력은 source/fixture/contract/evidence로 보존하지 않습니다.PR-0 / succession rule
이 PR은 #1193이 protected truth가 되기 전 단순 Close하지 않습니다. #1193이 prerequisites를 정상 통합하고 ordinary/non-force reconciliation 후 current-head repository/central gates, browser/a11y evidence, qualifying independent non-author approval을 획득해 Settings/Help delta의 protected succession이 검증되면 unmerged closure를 판단합니다.
No self-approval, force-push, destructive rebase, gate weakening, synthetic status, no-op freshness commit, blind rerun, predecessor-evidence transfer, or duplicate
App.tsxsource ownership.