Skip to content

preserve(ui): zero-delta PracticeProgress tooltip provenance pending #1226 - #1260

Draft
seonghobae wants to merge 8 commits into
developfrom
palette-practice-progress-tooltip-6673288047570169068
Draft

seonghobae wants to merge 8 commits into
developfrom
palette-practice-progress-tooltip-6673288047570169068

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

Preservation / succession status

This branch is provenance only; it is not an independent PracticeProgress accessibility source owner.

The generated Tooltip implementation is weaker than #1226: 32 CSS px +/- controls, no persistent localized boundary aria-describedby, no canonical Slider composition, and no focused hover/Escape/44px acceptance contract. #1226 owns the stronger visible SliderLabel, localized persistent boundary reasons, focus/hover/Escape evidence, 44 CSS px envelopes, finite 0–100 clamping, and the later userEvent.hover(...) focused-test refinement.

Fresh foreign-owner recurrence and repair

Earlier ordinary descendant 37cff27a558cbe8b6d133c4d6e5835283c4c05ff had restored the exact protected tree. Fresh live descendant 625baa0ae0e6bac65bd564907d7eafc75caa3f38 moved one commit ahead and changed only services/analysis-engine/tests/test_supply_chain_policy.py (+1/-3), the canonical #1176 Ruff formatter delta. No PracticeProgress, Slider, Tooltip, locale, test, or UI semantic delta accompanied that movement.

Ordinary descendant 16c97db90b49e611912fef23579e518c6272c5f3 uses 625baa0... as its parent and restores the exact protected develop tree. The branch ref advanced with force=false; the intervening generated commit remains in ancestry. This lane therefore owns no current product or formatter source.

Fresh exact-head workflow generation exists, but it is not terminal acceptance: build-baseline is in progress; repository CI, SBOM, Security Scan and Semgrep are queued; CodeQL is pending. No predecessor check or review receipt transfers across this source movement.

PR-0 / evidence boundary

Keep Open / Draft until #1226 or a verified successor preserves every valid source/test/evidence delta, reconciles #1176/#1188 through ordinary protected ancestry, obtains fresh exact-head repository/security and mounted browser/Electron pointer/touch/keyboard/zoom/forced-colors/AT evidence plus qualifying independent non-author approval, and reaches protected ancestry. Source/jsdom evidence is not mounted buyer acceptance.

No self-approval, force-push, destructive rebase, duplicate Tooltip source, copied #1176 formatter source, gate weakening, blind rerun, no-op freshness commit, synthetic status, predecessor-evidence transfer, or premature Close.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: e3f9323e-0739-41dc-9ff1-af301a5ffff6

📥 Commits

Reviewing files that changed from the base of the PR and between 314ddea and d5b3fb0.

📒 Files selected for processing (1)
  • apps/desktop/src/features/workspace/PracticeProgress.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

PracticeProgress.tsx의 증가 및 감소 버튼을 Tooltip 구성 요소로 감쌌습니다. 기존 title 속성을 번역 라벨을 표시하는 TooltipContent로 대체했습니다. 클릭 동작과 접근성 속성은 유지했습니다.

Changes

연습 진행률 버튼 툴팁

Layer / File(s) Summary
증가 및 감소 버튼에 툴팁 적용
apps/desktop/src/features/workspace/PracticeProgress.tsx
Tooltip, TooltipTrigger, TooltipContent import를 추가했습니다. 두 버튼의 title을 번역 라벨을 표시하는 툴팁으로 대체했습니다. 클릭 핸들러, aria-disabled, aria-label은 유지했습니다.

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to c89cf

No demonstrated issue blocks merging after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 PracticeProgress의 tooltip 변경을 명시하며 주요 변경 사항과 관련됩니다. 다만 세부 구현인 native title 대체까지는 설명하지 않지만, 제목으로서 충분히 구체적입니다.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Restore the protected PracticeProgress blob so this generated lane does not become a second accessibility writer. Canonical #1226 already owns the stronger Tooltip, persistent boundary description, 44 CSS px target, slider interaction envelope, and focused interaction evidence. Retain this generated commit in ancestry for provenance until protected succession satisfies PR-0.

Signed-off-by: Seongho Bae <me@seonghobae.me>
@seonghobae
seonghobae marked this pull request as draft September 23, 2026 14:19
@seonghobae seonghobae changed the title 🎨 Palette: 접근성 향상을 위한 PracticeProgress 툴팁 교체 preserve(ui): zero-delta PracticeProgress tooltip provenance pending #1226 Sep 23, 2026
seonghobae and others added 2 commits September 23, 2026 22:29
Keep fresh generated PracticeProgress Tooltip rewrite in ancestry while restoring the protected zero-delta tree. Canonical #1226 remains the stronger product owner for visible labeling, persistent boundary descriptions, 44px interaction targets, and focused Tooltip evidence.

Signed-off-by: Seongho Bae <me@seonghobae.me>

Copy link
Copy Markdown
Collaborator Author

Current authority update: fresh generated descendant 5dddae405105be3ead8edb2ccc511d6038e3c35a reintroduced the weaker PracticeProgress.tsx Tooltip rewrite after the prior zero-delta preservation repair. It kept 32px +/- controls and still lacked canonical #1226's visible SliderLabel, persistent localized boundary aria-describedby, 44 CSS px interaction envelope, and focused boundary interaction evidence. Ordinary descendant 091128c7892db4b25f30f8692c9239548e031378 uses 5dddae4... as parent and restores protected tree e30d0e0cd58aa67a5dad7254948717d796d0ce36 exactly. Branch advanced with force=false; intervening generated history remains ancestry. This PR remains Open/Draft preservation with zero product delta; #1226 remains canonical product owner. Predecessor checks/reviews do not transfer.

@google-labs-jules

Copy link
Copy Markdown

Current authority update: fresh generated descendant 5dddae405105be3ead8edb2ccc511d6038e3c35a reintroduced the weaker PracticeProgress.tsx Tooltip rewrite after the prior zero-delta preservation repair. It kept 32px +/- controls and still lacked canonical #1226's visible SliderLabel, persistent localized boundary aria-describedby, 44 CSS px interaction envelope, and focused boundary interaction evidence. Ordinary descendant 091128c7892db4b25f30f8692c9239548e031378 uses 5dddae4... as parent and restores protected tree e30d0e0cd58aa67a5dad7254948717d796d0ce36 exactly. Branch advanced with force=false; intervening generated history remains ancestry. This PR remains Open/Draft preservation with zero product delta; #1226 remains canonical product owner. Predecessor checks/reviews do not transfer.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

seonghobae and others added 4 commits September 24, 2026 03:33
Restore the protected tree so this zero-delta PracticeProgress provenance lane does not take ownership of #1176's Ruff-only supply-chain formatting. Canonical product semantics remain with #1226 and reusable Slider ownership remains with #1188. Preserve intervening generated commits in ancestry until protected succession satisfies PR-0.

Signed-off-by: Seongho Bae <me@seonghobae.me>
Remove the recurring foreign Ruff formatter delta from the PracticeProgress preservation lane. Keep the intervening generated commit in ancestry and restore the protected develop tree so #1176 remains the single formatter owner and #1226 remains the canonical PracticeProgress owner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant