fix: require Android 11 for screenshot execution - #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
The current screenshot execution path uses
AccessibilityService.takeScreenshot()and explicitly returns no screenshot below API 30. KeepingminSdk 24allowed Android 7–10 devices to install the APK even though core GUI-agent execution could not run.Testing
./gradlew assembleDebug— successful (194 tasks)aapt dump badgingsdkVersion: 30targetSdkVersion: 35git diff --checkDevice verification
Not run — no Android 15 device or emulator was connected. This change only adjusts the installation floor; the Android 11+ runtime execution code and backend protocol are unchanged.
Notes
Fixes #53