Repository navigation
ci: build pull requests - #118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the existing dev build workflow for pull requests in addition to pushes and manual dispatches.
Currently, the workflow runs
assembleDebugon pushes, but pull requests from forks do not trigger the workflow in the upstream repository. This means a PR can be opened without the existing build job validating it before merge.This adds the
pull_requesttrigger while leaving the existing build and artifact steps unchanged.Testing
The existing workflow is unchanged apart from its trigger. The build continues to run:
./gradlew assembleDebugExisting
pushandworkflow_dispatchtriggers remain enabled.