The "Publish" GitHub Actions workflow in Cratis/Components is failing (https://github.com/Cratis/Components/actions/r... - #228
Open
cratis-stagehand[bot] wants to merge 1 commit into
Conversation
Conformance/src/internal/metadata.ts imports the JSON schema asset that Source/scripts/copy-css.sh copies into dist/esm/schemas - an artifact Source's own abbreviated "build" script (tsc only) never produces, only "prepare" (tsc -b + rollup + copy-css) does. Conformance's own "build" script called plain tsc directly without preparing Core first, so any caller of `yarn workspace @cratis/components.conformance build` without a prior full Source build fails with TS2307. This is exactly what broke the Publish workflow in run 33336669545, since its "yarn build" step runs every workspace's plain "build" script in sequence. publish.yml has since been patched (PR #226) to run `yarn workspace @cratis/components prepare` before `yarn build`, which already fixes that workflow. This closes the same gap at its source so Conformance's own "build" script is self-sufficient regardless of the caller, matching the "prepare-core" pattern already used by its "typecheck-specs" script.
cratis-stagehand
Bot
added
the
no-release
Author
|
The `verify / verify` check (Verify Semver Label) was failing because this pull request had no release-intent label. Diagnosis and fix: this PR only changes `Conformance/package.json`'s `build` script to run `prepare-core` first - a build-tooling fix with no shipped artifact difference, matching the precedent set by the related publish-pipeline fixes in #222, #224 and #226, all labeled `no-release`. Applied the `no-release` label; the `verify` check now passes (run 33337529213). Ref: #229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
The Conformance package now runs the core preparation step before building, ensuring generated types are available during compilation. (#225)
Posted by Stagehand (AI) - an autonomous agent, not a person. Review accordingly.