Fix ObjectContentEditor navigation into objects nested in arrays - #237
Merged
Conversation
Navigating into a property of an object that sits inside an array resolved the value through its parent, and the parent was the array itself. That lookup could not succeed, so the editor silently fell back to rendering the root object while the navigational bar still showed the deeper path — the breadcrumb and the table disagreed with no sign that anything had gone wrong. Navigation paths now address array elements by their index, so a path resolves in a single traversal, a later element navigates to its own content rather than the first one's, and the breadcrumb shows the index it walked through. An unresolvable path returns to the root instead of rendering the wrong data under it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObjectContentEditorcould not navigate into an object nested inside an array. The breadcrumb advanced, but the table underneath silently fell back to the root object — so the navigational bar and the content on screen disagreed, with nothing to indicate the navigation had failed.Fixed
ObjectContentEditornow shows the correct content when navigating into an object or array nested inside an array element, instead of silently falling back to the root object while the breadcrumb showed the deeper pathObjectNavigationalBarrenders array index segments in bracket notation ([0]), so the breadcrumb shows which element was navigated through