Skip to content

Prepare 1.0.1: module registration and unit tests and bug fixes - #2

Merged
CrebsTheCoder merged 8 commits into
mainfrom
feature/1.0.1
Nov 5, 2026
Merged

Prepare 1.0.1: module registration and unit tests and bug fixes#2
CrebsTheCoder merged 8 commits into
mainfrom
feature/1.0.1

Conversation

@CrebsTheCoder

@CrebsTheCoder CrebsTheCoder commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Owner
  • Convert element registration to modules
  • Add unit tests
    • Entity
    • General
    • Simple
    • Teams
    • Registration
  • Bump version to 1.0.1

Bug fixes so far:

  • Fixed null UUID
  • Fixed possible null Boolean unboxing in the packet sneaking field.
  • Packet type lookup collisions
  • Packet-type variable key collisions
  • Invalid packet field return types
  • Glow viewers is declared singular (supposed to have multiple viewers)
  • Stale glow registrations
  • Unsafe chat-session cache
  • Glow removal ordering
  • Fixed NPE when player uuid is null

@github-actions

github-actions Bot commented Oct 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Qodana for JVM

6 new problems were found

Inspection name Severity Problems
Constant values 🔶 Warning 6

☁️ View the detailed Qodana report

Detected 26 dependencies

Third-party software list

This page lists the third-party software dependencies used in skPackets

Dependency Version Licenses
adventure-api 5.2.0 MIT
adventure-key 5.2.0 MIT
adventure-nbt 5.2.0 MIT
adventure-text-logger-slf4j 5.2.0 MIT
adventure-text-minimessage 5.2.0 MIT
adventure-text-serializer-gson 5.2.0 MIT
adventure-text-serializer-json 5.2.0 MIT
adventure-text-serializer-legacy 5.2.0 MIT
adventure-text-serializer-plain 5.2.0 MIT
annotations 26.1.0 Apache-2.0
auto-service-annotations 1.1.1 Apache-2.0
checker-qual 4.2.3 MIT
error_prone_annotations 2.48.0 Apache-2.0
examination-api 1.3.0 MIT
examination-string 1.3.0 MIT
failureaccess 1.0.3 Apache-2.0
fastutil 8.5.18 Apache-2.0
gson 2.14.0 Apache-2.0
guava 33.6.0-jre Apache-2.0
j2objc-annotations 3.1 Apache-2.0
joml 1.10.9 MIT
jspecify 1.0.0 Apache-2.0
listenablefuture 9999.0-empty-to-avoid-conflict-with-guava Apache-2.0
option 1.1.0 MIT
slf4j-api 2.0.17 MIT
snakeyaml 2.2 Apache-2.0
Contact Qodana team

Contact us at qodana-support@jetbrains.com

CrebsTheCoder
CrebsTheCoder commented Oct 29, 2026
View reviewed changes

@CrebsTheCoder CrebsTheCoder left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Image

@CrebsTheCoder
Fixed null UUID warnings
185a9df 
Fixed possible null Boolean unboxing in the packet sneaking field.
Added entity tests and JUnit/Mockito setup.
Added a test workflow, updated Gradle to 9.8.2, and changed README navigation/docs links to match the one in main.
CrebsTheCoder
CrebsTheCoder commented Oct 30, 2026
View reviewed changes

@CrebsTheCoder CrebsTheCoder left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Image

@CrebsTheCoder
Add general and simple module tests
d80b052
@CrebsTheCoder
Bug fixes
780c7c2 
Fix packet syntax collisions, field access, glow, and fake passengers
@CrebsTheCoder
Replace set.removeAll(list) with direct set removals.
4f3a753 
Add null-UUID regression tests.
Optimized Imports
CrebsTheCoder
CrebsTheCoder commented Oct 31, 2026
View reviewed changes

@CrebsTheCoder CrebsTheCoder left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Image

@CrebsTheCoder CrebsTheCoder changed the title Prepare 1.0.1: module registration and unit tests Prepare 1.0.1: module registration and unit tests and bug fixes Oct 31, 2026
@CrebsTheCoder
Finished teams test
e4b67a4
@CrebsTheCoder
Finished Tests and Bumped to 1.0.1 + Bug fixes
b5d3fe4 
Added some guard for some edge case that was probably removed bcuz qodana is feeding me false positives. This should prevent some npe.
@DRAGNIL68

DRAGNIL68 commented Nov 5, 2026

Copy link
Copy Markdown

sorry to say this but i think some of your tests did not pass

CrebsTheCoder
CrebsTheCoder commented Nov 5, 2026
View reviewed changes

@CrebsTheCoder CrebsTheCoder left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Should be good now inshallah

@CrebsTheCoder
CrebsTheCoder merged commit f512d78 into main Nov 5, 2026
4 checks passed
@CrebsTheCoder
CrebsTheCoder deleted the feature/1.0.1 branch November 6, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CrebsTheCoder @DRAGNIL68