Skip to content

feat: Show app version in window title + fix MCP docs - #4

Open
matixan wants to merge 2 commits into
masterfrom
feat/version-in-title
Open

matixan wants to merge 2 commits into
masterfrom
feat/version-in-title

Conversation

@matixan

@matixan matixan commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Display "CrossPad vX.Y.Z" in SDL window title bar using CMake-generated version header
  • Fix CLAUDE.md: MCP server path, exe name (main.exeCrossPad.exe), tool count (16 → 17), add missing crosspad_idf_build tool

Test plan

  • Build succeeds
  • Simulator shows correct version in title bar

🤖 Generated with Claude Code

matixan and others added 2 commits March 24, 2026 02:07
Display "CrossPad vX.Y.Z" in the SDL window title using the
CMake-generated version header, so users can identify which build
they're running at a glance.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- MCP server path: tools/mcp-server/ → crosspad-mcp (separate repo on GitHub)
- Executable name: bin/main.exe → bin/CrossPad.exe
- Tool count: 16 → 17 (add crosspad_idf_build)
- Add crosspad_idf_build to Build & Run tools table
- Update setup instructions to point to GitHub repo

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings March 24, 2026 01:12

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the PC simulator to show the build/version in the SDL window title and refreshes Claude integration docs to point at the external crosspad-mcp server repo and current executable/tooling names.

Changes:

  • Generate and display CrossPad vX.Y.Z in the emulator window title using CROSSPAD_PC_VERSION.
  • Update CLAUDE.md MCP server instructions, paths, executable name, and tool list (adds crosspad_idf_build).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/stm32_emu/Stm32EmuWindow.cpp Builds a versioned window title using the CMake-generated version header.
CLAUDE.md Updates build/run and MCP server documentation to match current tooling and repo layout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +140 to +141
std::string title = std::string("CrossPad v") + CROSSPAD_PC_VERSION;
lv_sdl_window_set_title(disp, title.c_str());

Copilot AI Mar 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CROSSPAD_PC_VERSION is generated as a string literal, the window title can be built via compile-time string literal concatenation (e.g., adjacent string literals) instead of constructing a std::string at runtime. This would avoid the allocation and the extra <string> include here.

Copilot uses AI. Check for mistakes.
@matixan
matixan enabled auto-merge March 24, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants