Skip to content

chore(greptile): enforce central best practices in reviews - #2115

Open
albertoelias-crossmint wants to merge 9 commits into
mainfrom
devin/1790634317-greptile-best-practices
Open

albertoelias-crossmint wants to merge 9 commits into
mainfrom
devin/1790634317-greptile-best-practices

Conversation

@albertoelias-crossmint

@albertoelias-crossmint albertoelias-crossmint commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Makes Greptile enforce the central engineering practices in Paella-Labs/best-practices on this repo's PRs. These are the same rules Devin and other agents get through AGENTS.md, and testing is one part of them.

  • context.repos: ["Paella-Labs/best-practices"]: Greptile reads the private repo as cross-repo context through the org's Greptile installation. That repo is consumed here, not reviewed. The rules reference files there instead of copying them, so a change in best-practices changes every review.
  • customContext.files: AGENTS.md, which holds the repo's commands, existing test setup and default PR evidence.
  • Compliance rule: PR changes and review comments must comply with best-practices (the org-wide files in manifest.txt plus typescript.md). Each flag cites the file and rule, and only the change itself is in scope, not pre-existing code.
  • Testing rule (addon): for new or changed behavior, it applies code/test.md and flags (1) no PR evidence of the feature working, (2) unit tests written after the code, (3) new behavior with no committed test, asking for E2E first, and (4) new tests that don't follow the repo's existing setup.

Pairs with #2116, which adds the AGENTS.md Testing section this config points at; merge them together.

Test plan

Config-only. greptile.json parses as JSON. The rules take effect on the next Greptile review.

Package updates

None (no package code changed, so no changeset).

Link to Devin session: https://crossmint.devinenterprise.com/sessions/7983bb75c26246418063bfe0d695e3c1
Open in Devin Desktop: https://crossmint.devinenterprise.com/desktop/session/7983bb75c26246418063bfe0d695e3c1?variant=devin
Requested by: @albertoelias-crossmint


Devin Review

Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access that start with 'Devin'.

  • Disable automatic comment, CI, and merge conflict monitoring

Original prompt from Alberto Elias

Extends the existing parallel plan with two additions — fold into the same workstreams:

  1. Greptile coverage (new Workstream 6, independent)

    • Copy the best-practices compliance rule from Paella-Labs/crossbit-main/greptile.json (the "Our engineering best practices are documented at..." entry) into a greptile.json / .greptile.json in every repo where Greptile is installed: crossmint-sdk, universal-checkout, open-signer, crossmint-kotlin-sdk, crossmint-flutter-sdk, crossmint-swift-sdk, solana-smart-account, stellar-smart-account, smart-wallet-modules, lobster.cash, devin-tools, paella-os. Repos that don't use Greptile can skip the file.
    • First verify whether Paella-Labs/best-practices is public — if private, Greptile can't fetch the URL, so either (a) make the repo public (it contains no secrets by design), or (b) inline the short testing policy verbatim in each greptile.json rule instead of linking. Prefer (a); document the choice in best-practices/README.md.
    • Add one testing-specific greptile rule per repo, adapted from crossbit-main's apps/**/libraries/** rule: reviewers should flag missing E2E artifacts and unit-tests-written-after-code on new changes only (incremental improvement, not retroactive enforcement).
  2. Artifact defaults (fold into existing workstreams 1, 3, 4, 5)

    • best-practices/core.md: expand the E2E bullet with the definition — "a self-contained output of the E2E run that lets a reviewer confirm the feature works without re-running it: captures evidence of what the system did, not just a pass/fail exit code. Each repo's AGENTS.md names its default artifact."
    • Each repo workstream adds one line to that repo's AGENTS.md under the testing section, per the defaults table: playwright report+trace for TS web/API repos; emulator/simulator report+recording for mobile SDKs; devnet/testnet tx signature for the smart contract repos (using deterministic seeds); CLI transcript/snapsho... (539 chars truncated...)

@changeset-bot

changeset-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 95f6fd4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@greptile-apps

greptile-apps Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

No reviewable files after applying ignore patterns.

devin-ai-integration[bot]

This comment was marked as resolved.

…issing PR evidence

Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
devin-ai-integration[bot]

This comment was marked as resolved.

Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
@devin-ai-integration devin-ai-integration Bot changed the title chore(greptile): add best-practices and testing review rules chore(greptile): enforce central best practices in reviews Sep 29, 2026
devin-ai-integration Bot and others added 5 commits September 29, 2026 20:13
Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
…e/test.md

Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>
Co-Authored-By: Alberto Elias <alberto.elias@paella.dev>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant