fix(marketplace): report our own commit and ship the licence files - #5
Merged
Merged
Conversation
The image reported commit-id 9e49d5e, the upstream release it derives from, while the binary was built from this fork. Anyone following that pointer to the corresponding source landed on a tree that is not the one they were given. SOURCE_COMMIT replaces the hardcoded pair and has no default, so a build that cannot say which commit it came from fails instead of repeating the wrong answer. The runtime stage carried no labels and no licence text either. LICENSE and CREDITS now ship at the same paths Dockerfile.release uses, and OCI labels name the source repository, revision and licence. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UhANRtjScVEw6pGs3uGaGC
Contributor
Author
|
리뷰어가 직접 봐야 하는 항목입니다. 판단은 하지 않았습니다. 1. 계획 항목 중 diff에 대응하는 변경이 없는 것
2. 계획이나 PR 본문에 언급되지 않은 변경 파일
3. 변경된 공개 인터페이스 (빌드 인자)
추가로 확인이 필요한 것 이미지에 들어가는 |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UhANRtjScVEw6pGs3uGaGC
Kim-YeongHyeon
changed the base branch from
release/2025-10-15-go1.25.9
to
main
September 15, 2026 04:34
main is the default branch now, so a PR against it matched no trigger. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UhANRtjScVEw6pGs3uGaGC
Kim-YeongHyeon
force-pushed
the
fix/marketplace-agpl-source-attribution
branch
from
September 15, 2026 04:42
3372868 to
573c099
Compare
Kim-YeongHyeon
marked this pull request as ready for review
September 15, 2026 04:42
alpine:3.23 preinstalls libcrypto3/libssl3 3.5.7-r0, which already satisfies ">=3.5.7-r0", so apk did nothing and the image shipped the version 3.5.8-r0 fixes. --upgrade makes the upgrade happen; the floor stays so a stale mirror fails the build rather than shipping quietly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UhANRtjScVEw6pGs3uGaGC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
발행된 이미지가 자기 소스를 잘못 가리킵니다.
9e49d5e7은 업스트림minio/minio커밋입니다. 실제 빌드 트리는 이 포크이고 업스트림보다 앞서 있습니다. 이미지 안에도 OCI 라벨과LICENSE/CREDITS가 없어, 받은 사람이 가진 유일한 포인터가 대응하지 않는 트리를 가리킵니다 (AGPL-3.0 §6).원인
Dockerfile.marketplace가 업스트림 커밋을 기본값으로 들고 있었습니다.기본값이라 아무도 넘기지 않아도 빌드가 성공하고, 커밋이 쌓여도 값은 그대로 남습니다.
채택한 해결 방안
위 두 인자를 기본값 없는
SOURCE_COMMIT하나로 대체. 짧은 해시는 여기서 파생하고, 값이 비면 빌드가 실패합니다.LICENSE,CREDITS를Dockerfile.release와 같은/licenses/경로로 포함.소스 레포·리비전·라이선스를 OCI 라벨로 명시.
sbom.yml이 유일한 호출부라 build-arg를 넘기도록 수정. PR 트리거에서는github.sha가 조회 불가능한 merge 커밋이라pull_request.head.sha를 우선합니다. 기본 브랜치가main이 되면서 트리거에main도 추가했습니다.openssl 업그레이드가 실제로 일어나게 수정.
alpine:3.23이libcrypto3/libssl33.5.7-r0을 미리 깔고 나오는데, 기존>=3.5.7-r0핀을 그게 이미 만족시켜서 apk가 아무것도 하지 않았습니다. 그 결과3.5.8-r0이 고치는 Critical 4건을 그대로 싣고 있었습니다.--upgrade로 올리고, 하한선은 남겨 미러가 낡았을 때 조용히 넘어가지 않고 빌드가 실패하게 했습니다.이 PR은 Dockerfile만 고칩니다. 이미 발행된 이미지는 재빌드·재push해야 반영됩니다.