Repository navigation
publication gate: apply 5dd43af (title hash check, Social Square phone flag) to main - #39
Merged
Merged
Conversation
…lag Social Square phone composition done (cherry picked from commit 5dd43af)
…ion flag generate_film_pages.py renders the 'phone composition is not finished' note from films/curation.json. With the flag true (previous commit), the note is dropped and nothing else on the page changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Applies the owner's commit
5dd43af("publication gate: fix title hash check to compare only title files; flag Social Square phone composition done") tomain. It was pushed topublication/title-social-squareat 19:45 EDT on 2026-10-17, 18 minutes after PR #33 merged that branch at 19:27:41 EDT (head679e38e). No PR carried it, so it never reachedmain.37417cd(cherry-pick of5dd43af,-x)scripts/publication_gate.py: compareverified_source_sha256against the two title files only.films/curation.json:same-scores__social-squarephone_compositionfalse → true2f572e2films/same-scores__social-square/index.htmlregenerated. The page renders its "phone composition is not finished" note fromcuration.json, sogenerate_film_pages.py --checkfailed without this. The diff removes that one sentence and nothing elsee09bb66sitemap.xml: onelastmodWhat this does and does not do
BLOCKED, on the third: no reader records. The deploy job still fails at "Enforce title, all phone films, and actual unfamiliar-reader evidence" until five unfamiliar readers are recorded.phone_composition: trueflag is an owner attestation that the Social Square phone composition is finished. The gate checks the render receipt (14px text audit at 280px, determinism, five pixel-equivalence samples), not whether the composition looks right. Merging this repeats your 2026-10-17 attestation.Evidence
Run in a fresh clone at
9f617d1(origin/main), branch tree ate09bb66.python3 scripts/publication_gate.py, exit 2 both times:maintitle: published title sources differ from the prepared title sources;phone films: same-scores__social-square: phone composition is unfinished;readers: five actual unfamiliar-reader records required; found 0readers: five actual unfamiliar-reader records required; found 0python3 -m unittest tests.test_publication_gate: 43 tests, OK, on the cherry-picked tree (37417cd). The manifest runs this file as "publication hold refusal paths".python3 scripts/verification_manifest.pyone09bb66: exit 0, 90 unique checks, the same as cleanmain. It ends withattribution: 66 bound commit(s), all Cubits11, no machine trailers.2f572e2the manifest failed onwatch page drift: films/same-scores__social-square/index.htmlandgenerate_film_pages.py --check. After regenerating, both pass.claims.yamlhas no claim that pinspublication_gate.py,films/curation.jsonorpublication/readiness.json.publication_gate.py --bindon the same fix in a throwaway worktree: it succeeds and pins 20 artifacts, includingindex.htmlandtry/index.html. It was not run in this branch and nothing is bound here.Not run
reproduce_cc001.py,verify_clean_clone.pyandsmoke_deployed.py(CI runs them). This draft is not to be merged by the author.