Repository navigation
crons: stop enabling auto-merge on cron-opened PRs - #43
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull requests opened by the scheduled cycles no longer enable auto-merge. Owner decision, 2026-11-02: cron-opened PRs must never auto-merge, because a merge into main requires a named owner yes.
Where auto-merge was enabled
One place. Both crons reach it:
scripts/queue_repository_update.py:57-59(at 7e5a667): after opening the PR, a GraphQLenablePullRequestAutoMerge(input:{pullRequestId:$id,mergeMethod:MERGE})request.scripts/cadence_cycle.sh:55andscripts/distribute_cycle.sh:40callscripts/queue_repository_update.py. Neither shell script enables auto-merge, and nothing under.github/does.The repository setting
allow_auto_mergeistrue. The ruleset "Evidence preservation — main" requires a pull request with 0 approvals and the checks "Claim registry" and "Reproduce bound artifacts". So an enabled auto-merge completed without a human once those checks passed.The exact change
scripts/queue_repository_update.py:tests/test_repository_update.py: the test that assertedmergeMethod:MERGEnow asserts the opposite:/repos/Cubits11/cubits11.github.io/pulls;enablePullRequestAutoMergein any call.It is renamed to
test_queue_opens_pull_request_without_auto_merge_and_returns_to_main.What does not change
claude/cycle-), the push, the PR title, head, base and body, and the return to main are byte-identical.scripts/cadence_cycle.sh,scripts/distribute_cycle.shand the crontab are untouched.allow_auto_mergesetting is unchanged.security/evidence-policy.json.Verification on this branch
py_compilepasses for both files.tests/test_repository_update.pyandtests/test_cadence_cycle.pypass.python3 scripts/verification_manifest.py:ok deterministic verification manifest: 90 unique checks, exit 0. Each of the 90 checks was also run individually: 90 exit 0.Auto-merge is off on this PR. Do not merge until CI is green and the owner has reviewed.