Skip to content

feat(frontend): stop losing unsaved edits and polish 57 rough edges across the app - #22

Merged
CubityFirst merged 65 commits into
mainfrom
design-picks
Nov 16, 2026
Merged

CubityFirst merged 65 commits into
mainfrom
design-picks

Conversation

@CubityFirst

Copy link
Copy Markdown
Owner

A design review of the whole app turned up two P1s:

  • The doc editor throws away unsaved work. Cancel or closing the tab discards it without asking.
  • A crash gives a blank page. The app has no error boundary, so /login renders blank when Turnstile fails to load.

The review also found a long tail of smaller inconsistencies. This PR applies all 57 fixes picked from that review. Each pick is its own commit, with its ID in the subject.

  • Critique (CRT1–5):
    • discard guard for unsaved doc edits;
    • Turnstile failure handling plus an app-level error boundary;
    • AlertDialogAction honours caller classes, so destructive confirms render red;
    • consistent wording (site, not project or workspace; one name for "Recent");
    • Shiki colours that meet AA.
  • Shell (SHL1–10): navigation, sidebar, dashboard and demo banner polish.
  • Docs (DOC1–10): editor and reader chrome, including readable dice in light theme and better dice labels for screen readers.
  • Files (FIL1–11): file manager menus, dialogs, empty states and previews.
  • Settings (SET1–10): settings layout, heading levels and danger-zone contrast.
  • Public (PUB1–11): landing, auth and the published reading view (no raw filenames, calmer landing effects).

The e2e text that changed is updated (demo.spec.ts banner, limited-permissions.spec.ts). Frontend typecheck, 922 unit tests and the production build pass locally on top of current main.

Not included:

  • The same treatment for ReportUserDialog.
  • Password-strength colours in user settings.
  • Blocking in-app navigation away from unsaved docs (needs a data router; tab close and Cancel are covered).

The listing sat in WIDE_CONTAINER (59rem), the doc-column width shared with
the dashboard, leaving wide empty margins on large screens. Add
TABLE_CONTAINER (fills the padded pane, capped and centred at 120rem) and use
it for the file manager so the flexible Name column takes the extra width.
…nded highlight instead of underlines (DOC10)
# Conflicts:
#	packages/frontend/src/layouts/DocsLayout.tsx
#	packages/frontend/src/pages/DashboardPage.tsx
@CubityFirst
CubityFirst merged commit d62ac7b into main Nov 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant