Repository navigation
feat(frontend): stop losing unsaved edits and polish 57 rough edges across the app - #22
Merged
Merged
Conversation
The listing sat in WIDE_CONTAINER (59rem), the doc-column width shared with the dashboard, leaving wide empty margins on large screens. Add TABLE_CONTAINER (fills the padded pane, capped and centred at 120rem) and use it for the file manager so the flexible Name column takes the extra width.
… recovery screen (CRT2)
…firms render red (CRT3)
…copy names the Edit button (CRT4)
…ounced outcome (DOC1)
…ebar is collapsed (SHL3)
…de its button (SET4)
…w and the box-in-a-box (SET6)
…ng the toggle (SET7)
…ty-state pattern (SHL6)
… its icons and label (SHL7)
…atch, distinct new colours (SET9)
… consistent consequences (SET10)
…greying it (FIL6)
…not the extension (FIL7)
…nded highlight instead of underlines (DOC10)
# Conflicts: # packages/frontend/src/layouts/DocsLayout.tsx # packages/frontend/src/pages/DashboardPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A design review of the whole app turned up two P1s:
/loginrenders blank when Turnstile fails to load.The review also found a long tail of smaller inconsistencies. This PR applies all 57 fixes picked from that review. Each pick is its own commit, with its ID in the subject.
AlertDialogActionhonours caller classes, so destructive confirms render red;The e2e text that changed is updated (
demo.spec.tsbanner,limited-permissions.spec.ts). Frontend typecheck, 922 unit tests and the production build pass locally on top of currentmain.Not included:
ReportUserDialog.