Skip to content

check_cards.py exits 0 when it could read nothing at all #115

Description

@realmarcin

From the review of #109.

By design a fetch that fails is a warning, not a failure, so a single site's outage does not paint the nightly red. But the same rule means a run in which all ten fetches fail — network blocked on the runner, the whole Pages host down, a bad SITE constant — prints 0 match, 0 drifted, 10 unreadable and exits 0. A check that verified nothing reports success.

Worth deciding rather than assuming: fail when nothing matched at all, or when unreadable exceeds some fraction, while keeping the single-outage case green. Filed for judgment, not changed in #109.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions