Skip to content

PR #120 omits the per-edit evidence table its own skill requires #137

Description

@realmarcin

Found in the adversarial review of #120.

PR omits the per-edit evidence table that its own skill requires

Where: .claude/skills/update-xmech-page/SKILL.md:235

The skill requires 'Evidence for every changed figure. A URL or path@sha and a verbatim excerpt' (line 49), and step 10 says to open the PR with 'the evidence table for hand-curated edits'. The PR calls itself the skill's first run, but its body only summarises the hand-curated changes: three reversed arrows, three new XREFS, the HUB reclassifications, six reworded generalizations and two new Explore links. It gives no URL or path@sha and excerpt for any of them. The PR has no comments, and site_audit.json notes cover only the card figures.

Failure scenario. A reviewer cannot check that the TraitMech→ProteinTraitsMech or HabitatMech→TaxonMech references exist upstream, or that the HUB 'namespace' downgrades are right, without redoing the 533-claim audit. The adversarial review step the skill mandates has nothing to check these edits against.

Evidence. gh pr view 120 --json body has no table of URL or path@sha per hand-curated edit. gh pr view 120 --json comments,reviews is empty. In the XREFS diff, CellStructureMech→TraitMech became TraitMech→CellStructureMech and HabitatMech→TraitMech became TraitMech→HabitatMech, and HabitatMech→TaxonMech, TraitMech→ProteinTraitsMech and TraitMech→TaxonMech were added. None of these has evidence in the PR.

Verifier (partly, low). PR #120 does not include the evidence table for hand-curated edits that SKILL.md step 10 (lines 235-237) requires. The body gives only prose bullets, and there are no comments, reviews or issues holding the auditors' table. The new and reversed XREFS entries can still be checked from the diff: each carries an ev file pointer and a url (blob/main, not path@sha, no excerpt), and the TraitMech→ProteinTraitsMech and HabitatMech/TraitMech→TaxonMech references check out at the pins (5f05fca, 972fbd7). The unevidenced edits are the HUB reclassifications (CultureMech and CommunityMech from export to namespace, TraitMech to inbound DeepWalk embeddings, the reworded TaxonMech and CommunityMech inputs) and the six reworded generalizations, which have no source pointer anywhere in the PR or the diff. The fix is to attach per-edit rows (URL or path@sha plus a verbatim excerpt), at least for the HUB and generalization edits, and ideally to switch the XREFS urls to pinned revisions.

Suggested fix. Attach the auditors' surviving-change table to the PR (body or a comment), one row per hand-curated edit with a URL or path@sha and a verbatim excerpt.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions