From the round-2 review of #212.
Where: scripts/fleet/check_cards.py:22-23.
The docstring says STALE applies when "the card understates the site by more than MAX_LEAD". Measured against the site, the way the constants comment uses "understates", that is site > 2 × card. The code fails at site > 1.5 × card (site - card > card * MAX_LEAD), which is what the constants comment, the README and the PR body say.
Fix: "the site leads the card by more than MAX_LEAD of the card (the card then understates it by over a third)".
From the round-2 review of #212.
Where:
scripts/fleet/check_cards.py:22-23.The docstring says STALE applies when "the card understates the site by more than MAX_LEAD". Measured against the site, the way the constants comment uses "understates", that is site > 2 × card. The code fails at site > 1.5 × card (
site - card > card * MAX_LEAD), which is what the constants comment, the README and the PR body say.Fix: "the site leads the card by more than MAX_LEAD of the card (the card then understates it by over a third)".