From the round-3 review of #212.
Where: .github/workflows/fleet-page.yml, the check_cards step, whose if: has no status function and so gets an implicit success().
A mistyped card or an unreadable pinned_at_utc fails test_every_card_equals_the_figure_its_source_stated_at_the_pin in the unit-test step. The card check is then skipped. The nightly goes red, but its log has no WRONG or AUDIT line and no remedy, and every other card result from that night (GONE, STALE) is hidden too. #212's commit and PR body say the nightly reports WRONG.
Fix: run the card check on schedule or dispatch even when an earlier step failed (!cancelled() && (...)), so its report always prints.
From the round-3 review of #212.
Where:
.github/workflows/fleet-page.yml, the check_cards step, whoseif:has no status function and so gets an implicitsuccess().A mistyped card or an unreadable
pinned_at_utcfailstest_every_card_equals_the_figure_its_source_stated_at_the_pinin the unit-test step. The card check is then skipped. The nightly goes red, but its log has no WRONG or AUDIT line and no remedy, and every other card result from that night (GONE, STALE) is hidden too. #212's commit and PR body say the nightly reports WRONG.Fix: run the card check on schedule or dispatch even when an earlier step failed (
!cancelled() && (...)), so its report always prints.