Skip to content

check_cards: the closing line sends a WRONG card to a full refresh; the README gives it its own remedy #240

Description

@realmarcin

From the round-3 review of #212.

Where: scripts/fleet/check_cards.py main() closing line, and _fleet/README.md's remedy list.

The closing line groups WRONG with STALE and SHRANK under "refresh the card figures (update-xmech-page)", which is a full re-pin. The README, which says it restates the closing line, lists WRONG separately as a mistyped card. Following the script turns a one-character fix into a fleet refresh, which step 8 of the skill warns against.

Fix: give WRONG its own clause: set the card, or the audit's figure_at_pin if the audit is what's wrong, to agree with the pinned source.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions