From the round-3 review of #212 (follows #232, #234).
Where: tests/test_fleet_page.py CardCheckTests.
Mutation testing found these unguarded:
- Missing
pinned_at_utc: gives an AUDIT row, untested.
- AUDIT on its own: an unreadable pin time with every site equal should still fail the run, untested.
- No offset means UTC: the naive-time test would also pass if a naive time were read as local time.
- The grace period: the tests read
GRACE_DAYS rather than pinning the documented 14.
- The 4xx edges: 400 and 499 (GONE) and 500 (unread) are not asserted.
Fix: add a case for each.
From the round-3 review of #212 (follows #232, #234).
Where:
tests/test_fleet_page.pyCardCheckTests.Mutation testing found these unguarded:
pinned_at_utc: gives an AUDIT row, untested.GRACE_DAYSrather than pinning the documented 14.Fix: add a case for each.