From the round-4 review of #212.
Where: scripts/fleet/check_cards.py read_source().
The message is built as f"{kind} shape changed; {where} found". For CultureMech, where is "the generated block that states it", so the log reads "text shape changed; the generated block that states it found", which is the opposite of the truth. It appears both when the markers are missing and when the block has no figure. Commit e0775e5 in this PR introduced it; the previous wording said the block "is gone". The test checks only the status, so nothing noticed.
Fix: reword the message to say the block is missing or states no figure, and assert the text in the test.
From the round-4 review of #212.
Where:
scripts/fleet/check_cards.pyread_source().The message is built as
f"{kind} shape changed; {where} found". For CultureMech,whereis "the generated block that states it", so the log reads "text shape changed; the generated block that states it found", which is the opposite of the truth. It appears both when the markers are missing and when the block has no figure. Commit e0775e5 in this PR introduced it; the previous wording said the block "is gone". The test checks only the status, so nothing noticed.Fix: reword the message to say the block is missing or states no figure, and assert the text in the test.