Skip to content

update skill step 11's guard matches names as regexes and accepts a directory named *.log #252

Description

@realmarcin

From the Codex review of #216, after five internal rounds.

Where: .claude/skills/update-xmech-page/SKILL.md step 11: grep -v -x -e revisions.json -e mechs -e claw -e '.*\.log'.

The allowed names are unescaped regular expressions, so revisions.json also matches revisionsXjson. ls -A gives names without types, so a directory named notes.log/ counts as a log. With the three markers present, either leaves $extra empty, and the step removes unrelated work.

Fix: compare names literally, and accept a *.log entry only if it is a regular file.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions