Skip to content

check_cards tests: #250's shape guards and #248's remedy content survive mutation #259

Description

@realmarcin

From the round-5 review of #212.

Where: tests/test_fleet_page.py.

These pass all 73 tests:

  • Removing the list check on repositories: {"repositories": 5} then raises TypeError.
  • Removing audit = None after an audit problem: [1] then raises.
  • Dropping any named copy from WRONG's remedy.

Fix:

  • add {"repositories": 5}, [1], {} and a null file to the malformed-audit tests;
  • assert that the remedy names fleet_fragment.html, card_records and the grep for the old figure.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions