From the Codex review of #212, after five internal rounds.
Where: scripts/fleet/check_cards.py check(), and the provenance test.
With HabitatMech's card mistyped as 3,026 and the audit's figure_at_pin stored as "3206" or 3206.0, the check skips WRONG and reports "grew", exit 0, with no AUDIT row. The provenance test also accepts 3206.0, because 3206.0 == 3206 in Python. A Mech whose source has a committed copy but whose entry lacks figure_at_pin is skipped the same way.
Fix:
- report AUDIT when
figure_at_pin is present but not an int, or missing for a source that has a committed copy (every source except ProteinTraitsMech);
- make the provenance test require an int.
From the Codex review of #212, after five internal rounds.
Where:
scripts/fleet/check_cards.pycheck(), and the provenance test.With HabitatMech's card mistyped as 3,026 and the audit's
figure_at_pinstored as"3206"or3206.0, the check skips WRONG and reports "grew", exit 0, with no AUDIT row. The provenance test also accepts3206.0, because3206.0 == 3206in Python. A Mech whose source has a committed copy but whose entry lacksfigure_at_pinis skipped the same way.Fix:
figure_at_pinis present but not an int, or missing for a source that has a committed copy (every source except ProteinTraitsMech);