Skip to content

check_cards: a duplicate card can hide a wrong figure in the nightly #262

Description

@realmarcin

From the Codex review of #212.

Where: scripts/fleet/check_cards.py check() and scripts/fleet/card_markup.py.

card_figures() keeps the last card for each name, and card_names() is turned into a set, which discards the count. Prepend a HabitatMech card stating 3,026 before the real 3,206 one, and the nightly reports all ten ok and exits 0. assemble() rejects the duplicate, but the card check clears it.

Fix: report a Mech with more than one card as MARKUP in markup_problems(), which both the check and the assembler use.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions