From the round-1 review of #265 (follows #248, #258).
Where: scripts/fleet/check_cards.py main() closing line, and _fleet/README.md's WRONG bullet.
Both say to correct "the audit's figure_at_pin if that is what was mistyped". With #265, figure_at_pin is derived by build_site_audit.py from the source's committed copy at the pin, and the README says the mechanical fields are never typed. A hand edit of the field would be the same class of typo the builder exists to prevent.
Fix: tell the reader to re-derive figure_at_pin with the builder, against a snapshot at the audit's pins (update skill step 11 says how), rather than edit it.
From the round-1 review of #265 (follows #248, #258).
Where:
scripts/fleet/check_cards.pymain()closing line, and_fleet/README.md's WRONG bullet.Both say to correct "the audit's figure_at_pin if that is what was mistyped". With #265,
figure_at_pinis derived bybuild_site_audit.pyfrom the source's committed copy at the pin, and the README says the mechanical fields are never typed. A hand edit of the field would be the same class of typo the builder exists to prevent.Fix: tell the reader to re-derive
figure_at_pinwith the builder, against a snapshot at the audit's pins (update skill step 11 says how), rather than edit it.