Skip to content

Census folds entity-qualified namespaces for some registries but not others #271

Description

@realmarcin

From the round-2 review of #244 (#84).

The census folds entity-qualified namespaces into their registry for some registries:

The same shape stays unfolded for other counted heatmap registries:

namespace registry Mech occurrences
gtdb.genome GTDB TaxonMech 135,164
pdb.ligand PDB ProteinTraitsMech 14,863
pdb-ccd PDB AntibioticMech 333
uniprot.location UniProt CellStructureMech 656
uniprot.ptm UniProt ProteinTraitsMech 468
UniProtKB-KW UniProt ProteinTraitsMech 127
RHEA-COMP RHEA ProteinTraitsMech 11,169, in grounding: fields

TaxonMech's genome_id: field holds both img.taxon: (counted) and gtdb.genome: (dropped). The README's stated rule doesn't match the code.

Fix: write down one rule and apply it evenly. The precedent in norm is to fold every namespace named for or qualified by a counted registry into that registry.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions