Skip to content

build_site_audit reads a commit_date with no offset as local time, while pin_time reads one as UTC #274

Description

@realmarcin

From the round-2 review of #265.

Where: scripts/fleet/build_site_audit.py utc(), and step 1's revisions.json layout in the update skill.

utc() calls .astimezone(timezone.utc), which reads a naive time as the machine's local zone. On a PDT machine, 2026-09-21T08:37:02 becomes 15:37:02Z, silently. check_cards.pin_time() reads a naive time as UTC. Step 1's layout gives commit_date only as "<ISO>".

Fix: refuse a commit date with no offset. Say in step 1 that it is the committer date with its offset.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions