From the round-4 review of #265 (follows #276).
Where: scripts/fleet/check_cards.py closing line, and _fleet/README.md's remedy list.
- Deleted file:
git log -p _fleet/data/site_audit.json exits 128 once the file is deleted. It needs -- before the path.
- PR body: the refresh PR body carries short shas and no pin time, so it can't supply what the bad-pin-time case needs.
- Malformed audit: unparseable JSON, a non-object, or no repositories list has no clause. Only a "missing audit" does.
card_records: WRONG tells the reader to correct card_records in site_audit.json, while AUDIT says never to edit the file by hand. It is the one field a WRONG fix must change to match the corrected card, and a test requires it to equal the card.
Fix:
- use
git log -p -- <path>;
- drop the PR body as a source;
- cover a malformed audit;
- state the
card_records exception.
From the round-4 review of #265 (follows #276).
Where:
scripts/fleet/check_cards.pyclosing line, and_fleet/README.md's remedy list.git log -p _fleet/data/site_audit.jsonexits 128 once the file is deleted. It needs--before the path.card_records: WRONG tells the reader to correctcard_recordsinsite_audit.json, while AUDIT says never to edit the file by hand. It is the one field a WRONG fix must change to match the corrected card, and a test requires it to equal the card.Fix:
git log -p -- <path>;card_recordsexception.