From the round-3 review of #244.
Where: tests/test_fleet_page.py PrefixListTests.setUp, literal_prefix().
The helper only turns \. back into .. #244 adds pdb\-ccd, RHEA\-COMP, CAS\-RN and UniProtKB\-KW to P. For those four, the set the test calls "what the census can actually emit" holds the backslashed strings, and norm, keyed by the unescaped names, is never applied to them. The invariant tests pass today only because none of those four names is a heatmap column.
Fix: unescape every regex escape. Add an assertion that every alternative in P maps through norm to a name the census emits.
From the round-3 review of #244.
Where:
tests/test_fleet_page.pyPrefixListTests.setUp,literal_prefix().The helper only turns
\.back into.. #244 addspdb\-ccd,RHEA\-COMP,CAS\-RNandUniProtKB\-KWtoP. For those four, the set the test calls "what the census can actually emit" holds the backslashed strings, andnorm, keyed by the unescaped names, is never applied to them. The invariant tests pass today only because none of those four names is a heatmap column.Fix: unescape every regex escape. Add an assertion that every alternative in
Pmaps throughnormto a name the census emits.