Skip to content

Build the census before opening the file it overwrites #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realmarcin merged 1 commit into from
Sep 22, 2026
Merged

Build the census before opening the file it overwrites #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion scripts/fleet/prefix_census.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,16 @@ def census():


def main():
json.dump(census(),open(DATA+"/prefix_census.json","w"),indent=1)
# Build the document before opening the file. `json.dump(census(), open(...))`
# happens to be safe because arguments evaluate left to right, so a scan that
# exits takes the process down before the truncation — but write it the
# idiomatic way, with the open first, and a missing checkout leaves the
# committed census at zero bytes. census() exits for ordinary reasons:
# roots.mech_root when a checkout is absent, record_paths when a glob matches
# nothing, both deliberately fail-closed. Also closes the handle (#102).
document = census()
with open(DATA + "/prefix_census.json", "w") as handle:
json.dump(document, handle, indent=1)


# Guarded so the module can be imported for P, rx and norm alone. Without this
Expand Down
Loading