fix: skillnet-ai 0.1.x compatibility (JSON output, download layout, analyze flags) - #1
Merged
Merged
Conversation
- Read search/download results from --json ({ok, data, error}) instead of scraping the table
- import_best_skill/get_skill_rules: use the downloaded path (<target>/<skill-name>/) so SKILL.md is found
- analyze_skills: replace removed --save/--no-save with output_dir and force
- download_skill: overwrite option; token passed as GITHUB_TOKEN, not on the command line
- health_check via `skillnet doctor --json`; SKILLNET_BIN for CLIs outside PATH
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skillnet-ai 0.1.x changed the CLI in ways that break several tools. This PR adapts the server to 0.1.2:
--json({ok, data, error}) instead of regex-scraping the rich table. CLI errors now come back with their message and hint (e.g.Destination exists; use --overwrite).import_best_skill/get_skill_rules: the CLI writes a skill to<target>/<skill-name>/, so both tools listed the target directory, found noSKILL.md, and answered "No .md documentation found". They now use the path the download reports, and existing caches are resolved the same way.analyze_skills:--save/--no-savewere removed in 0.1.x, so the tool now takesoutput_dirandforce.download_skill: newoverwriteoption. The token is now handed over asGITHUB_TOKENinstead of-t <token>, which keeps it out of the process list (the CLI's own help recommends this).health_check: usesskillnet doctor --jsonand reports the CLI version. A newSKILLNET_BINvariable points at a CLI outsidePATH, e.g. auv toolinstall.package.json.Testing
npm test: 19 passed. New tests cover JSON parsing, result formatting and skill-folder resolution. Command-builder expectations are updated.health_checkandsearch_skillssucceed.import_best_skillandget_skill_ruleswith topicpdfdownload to.temp_skills/pdf/summarize/SKILL.mdand return its content. Before this change they returned "No .md documentation found".GitHub API Error [301]. The tool now reports that error cleanly.🤖 Generated with Claude Code